feat(gnokey): -broadcast=true by default

[leohhhn]

Description

Flips the broadcast flag in gnokey to true by default.

cc @moul can we please do this? Makes so much sense: makes using gnokey easier, makes writing docs easier, and is still there if someone wants to explicitly disable it.

For 99% of people this should be on by default.

[Gno2D2]

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: leohhhn/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🟢 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gno.land/pkg/keyscli/maketx.go	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[thehowl]

I think the UX should likely be -dst <FILE> or -local, so that having the current behaviour is possible through gnokey maketx -dst -.

I agree that this simplifies UX greatly. I'm thinking of security implications, but I think that if someone were to understand that they need to use an offline device to do their transactions, they wouldn't have the key on their online device anyway.

So I support this.

[moul]

-dst or -airgap; I personally prefer the term airgap to be displayed in the --help section to assist people in discovering and using it.

[leohhhn]

@moul

I can make -broadcast into -airgap with the functionality flipped. wdyt?

[thehowl]

putting in review comment to remove review team label; this is not required for mainnet so outside of current scope of work IMO