Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): object deletion; add comments #3741

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix(gnovm): object deletion; add comments #3741

merged 1 commit into from
Feb 13, 2025

Conversation

petar-dambovaliev
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev commented Feb 12, 2025

Closes 3688

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 12, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 12, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will definitely require a second look, probably @ltzmaxwell or @thehowl as I'm unsure of all the implications of switching to isDeleted. However, the comment left above isDeleted appears coherent.
Other comments on ObjectInfos properties bring clarity and are really helpful. Thanks for adding that.

gnovm/pkg/gnolang/ownership.go Show resolved Hide resolved
gfanton

This comment was marked as duplicate.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thehowl thehowl changed the title fix: object deletion; add comments fix(gnovm): object deletion; add comments Feb 13, 2025
@thehowl thehowl merged commit c61e217 into master Feb 13, 2025
82 of 83 checks passed
@thehowl thehowl deleted the oak-2 branch February 13, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

Implement 20250127-OAK-02
4 participants