fix: interface to concrete type by T(ifaceVal) is not allowed #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
petar-dambovaliev
force-pushed
the
3412
branch
from
9e6f5e1 to
e195990
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
notJoon
approved these changes
Feb 17, 2025
ltzmaxwell
requested changes
Feb 17, 2025
| @@ -1423,7 +1424,16 @@ func preprocess1(store Store, ctx BlockNode, n Node) Node { | |||
| checkOrConvertType(store, last, n, &n.Args[0], ct, false) | |||
| } | |||
| default: | |||
| // do nothing | |||
| ctBase := BaseOf(ct) | |||
There was a problem hiding this comment.
nitpick:
Suggested change
| ctBase := BaseOf(ct) | |
| ctBase := baseOf(ct) |
Comment on lines
+1428
to
+1436
| atBase := baseOf(at) | ||
|
|
||
| _, isCTInterface := ctBase.(*InterfaceType) | ||
| _, isCTNative := ctBase.(*NativeType) | ||
| _, isATInterface := atBase.(*InterfaceType) | ||
|
|
||
| if (!isCTInterface && !isCTNative) && isATInterface { | ||
| panic(fmt.Sprintf("cannot convert %v to %v: need type assertion", at.TypeID(), ct.TypeID())) | ||
| } |
There was a problem hiding this comment.
and it would be better the whole new added logic happens before the switch.
|
These are missing checks for type casting between interfaces. See this: we can fix it in another PR tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 3412