-
Notifications
You must be signed in to change notification settings - Fork 417
feat: r/coins
balance checker
#3899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: moul <[email protected]>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
If you add TotalSupply in this PR, just linking this PR as well for the docs: #2661 |
can we stop using the term "airdrop" for this feature (PR title, and a unit test having the term in the title); this PR isn't an airdrop checker, but a balance checker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; we can make the rendering better in the next iteration.
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
If Jae can't review this PR by EOD, let's merge it tomorrow. We've reduced complexity, there shouldn't be anything in it that can't be rolled back easily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Implemented the token inquiry function. Currently, only the feature to check coins at a specific address is provided, and the function to check the total quantity is not yet supported.
Example Usage:
/r/gnoland/coins:ugnot
- shows the total supply of ugnot/r/gnoland/coins:ugnot/g1...
- shows the ugnot balance of a specific addressRelated
TotalCoin
reference #2661