feat: `r/coins` balance checker #3899

notJoon · 2025-03-10T04:21:05Z

Description

Implemented the token inquiry function. Currently, only the feature to check coins at a specific address is provided, and the function to check the total quantity is not yet supported.

Example Usage:

/r/gnoland/coins:ugnot - shows the total supply of ugnot
/r/gnoland/coins:ugnot/g1... - shows the ugnot balance of a specific address

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: notJoon/gno-core)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Must not contain the "don't merge" label

If

🟢 Condition met
└── 🟢 A label matches this pattern: don't merge (label: don't merge)

Then

🔴 Requirement not satisfied
└── 🔴 On no pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 And
            ├── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
            └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission

codecov · 2025-03-10T04:32:03Z

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gnovm/tests/stdlibs/std/std.go	0.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

leohhhn · 2025-03-10T16:58:28Z

If you add TotalSupply in this PR, just linking this PR as well for the docs: #2661

moul · 2025-03-10T16:59:30Z

can we stop using the term "airdrop" for this feature (PR title, and a unit test having the term in the title); this PR isn't an airdrop checker, but a balance checker.

moul · 2025-03-10T18:33:13Z

examples/gno.land/r/gnoland/coins/coins.gno

+)
+
+// TotalSupply returns the total supply of the specified denomination
+func TotalSupply(banker std.Banker, denom string) int64 {


can we have this API instead, and always use a readonly banker?

Suggested change

func TotalSupply(banker std.Banker, denom string) int64 {

func TotalSupply(denom string) int64 {

Modified it so that the banker object is created inside the function. I also considered placing the banker globally, but it seemed better to restrict the object's lifetime to within the function (It's also purer than global).
695412e

moul · 2025-03-10T18:34:13Z

examples/gno.land/r/gnoland/coins/coins.gno

+}
+
+func renderHomepage() string {
+	return `# Gno.land Coins


homepage should give some information, and provide default links so that we can try the features with just a few clicks.

This is currently a placeholder. It is must be updated later.

moul · 2025-03-10T18:34:37Z

examples/gno.land/r/gnoland/coins/coins.gno

+## Total Supply
+` + std.NewCoin(denom, totalSupply).String() + `
+
+[Back to Home](/r/gnoland/coins:)


back is already available in the navigation breadcrumb.

removed 695412e

moul · 2025-03-10T18:35:39Z

examples/gno.land/r/gnoland/coins/coins.gno

+[Back to Coin Info](/r/gnoland/coins:` + denom + `)
+[Back to Home](/r/gnoland/coins:)


remove this, we should use the navigation breadcrumb for this.

moul · 2025-03-10T18:37:56Z

examples/gno.land/r/gnoland/coins/coins_test.gno

+	}
+
+	for _, tt := range tests {
+		banker := std.NewBanker(std.BankerTypeRealmIssue)


why do we need to initialize a banker from this realm?

(if there is a good reason, why not a readonly one?)

In std.BankerTypeReadonly mode, issuing coins are blocked, so I use std.BankerTypeRealmIssue mode only when setting up the test environment.

I think there won't be any issues because the inside of the TotalSupply or AddressBalance functions are set to read-only (modified to create a banker internally). please correct me, if I wrong.

moul · 2025-03-10T18:38:47Z

gno.land/pkg/sdk/vm/builtins.go

+	for _, acc := range accounts {
+		if acc == nil {
+			continue


Not scalable. We need to find a more efficient solution, or we should refrain from offering this feature for now.

I modified this function to process in a single loop. This is what I could think of for now. What do you think?

0d751b6

This needs a change in the underlying banker module, so that it keeps track of the available tokens, rather than iterating on the accounts here.

moul

check comments.

notJoon · 2025-04-14T08:11:57Z

@notJoon

Let's split this PR in to the balance checker and the banker edits. Either way we'd like to merge the balance checker soon, and let's just leave todo's regarding the total supply.

bfee6be

moul · 2025-04-14T08:53:52Z

@notJoon, this is still not good. Please do not modify the tm2 code at all in this PR; just examples/.

notJoon · 2025-04-14T11:26:02Z

this is still not good. Please do not modify the tm2 code at all in this PR; just examples/.

@moul
It seems we have different understandings of the implementation method. I originally understood that this functionality would be implemented using "banker-related workflows" and std.NewBanker as mentioned in the comments and the Render function in original PR. That's why I implemented the TotalCoin function before, and when I referred to the previous review, I understood we were moving in this direction.

If possible, could you clarify the implementation direction for the r/coins package? Currently, besides the examples, the only modified part is the mock function for testing TotalCoin. If this also needs to be reverted, I think r/coins will remain just a placeholder, and I don't get it how will be implemented and used.

If we're not using banker, using grc20's token-related functions seems like the most possible alternative option.

I should have confirmed this before starting, but it seems something went wrong from the beginning. I would appreciate your confirmation on this. Thank you.

moul · 2025-04-14T11:37:17Z

r/coins needs to display balances (using banker). Most of this PR code focuses on total supply, which is more complex and not urgently needed (we'll address that later). For now, r/coins should concentrate on displaying the user balance for a specific coin.

There should be a .gno file for the realm that includes only a Render function, along with a few helpers and some unit tests.

Initial specifications can be found at https://github.com/gnolang/gno/pull/3826/files. Please ignore the total supply, as it is not yet supported.

notJoon · 2025-04-16T08:09:28Z

@moul I've made modifications like this, what do you think? I've modified it to exclude the total supply and only provide the balance inquiry function for specific addresses.

1978a90

leohhhn

Looks good; we can make the rendering better in the next iteration.

leohhhn · 2025-04-22T15:10:28Z

examples/gno.land/r/gnoland/coins/coins.gno

+	router.HandleFunc("{denom}", func(res *mux.ResponseWriter, req *mux.Request) {
+		// denom := req.GetVar("denom")
+		// banker := std.NewBanker(std.BankerTypeReadonly)
+		// res.Write(renderAddressBalance(banker, denom, denom))
+		panic("not supported yet")
+	})


I think this would error and make the user experience a bit worse; maybe a better option is to simply write out "page coming soon" or similar.

examples/gno.land/r/gnoland/coins/coins.gno

leohhhn · 2025-04-22T15:11:59Z

examples/gno.land/r/gnoland/coins/coins.gno

+func formatBalance(coin std.Coin) string {
+	return "Balance: " + strconv.Itoa(int(coin.Amount)) + " " + coin.Denom
+}


Nitpick: you can use std.Coin.String()

This can also reduce function calls and package usage. That's a very good suggestion.
16ed599

examples/gno.land/r/gnoland/coins/coins.gno

Co-authored-by: Leon Hudak <[email protected]>

moul and others added 2 commits February 25, 2025 13:09

feat(examples): add r/gnoland/coins

c59d58d

Signed-off-by: moul <[email protected]>

feat: TotalCoin

a654e50

github-project-automation bot added this to 💪 Bounties & Worx and 🧙‍♂️gno.land core team Mar 10, 2025

github-project-automation bot moved this to Triage in 🧙‍♂️gno.land core team Mar 10, 2025

github-actions bot assigned notJoon Mar 10, 2025

github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Mar 10, 2025

Gno2D2 requested a review from a team March 10, 2025 04:21

notJoon added 2 commits March 10, 2025 13:22

Merge branch 'master' into airdrop-checker

df1bf50

fix

c0b825a

test: mock TotalCoin

b12bbe7

github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Mar 10, 2025

notJoon added 4 commits March 10, 2025 17:39

fmt

ee072ef

fix

9cb5c81

fix: create proper denom

dc636d3

doc

ef43e83

Kouteki moved this from Triage to In Progress in 🧙‍♂️gno.land core team Mar 10, 2025

moul reviewed Mar 10, 2025

View reviewed changes

moul requested changes Mar 10, 2025

View reviewed changes

github-project-automation bot moved this to In Progress in 💪 Bounties & Worx Mar 10, 2025

notJoon added 2 commits April 3, 2025 18:22

Merge branch 'master' into airdrop-checker

c5a012b

fix

4cbd61c

notJoon changed the title ~~feat: Implement banker.TotalSupply and r/coins balance checker~~ feat: r/coins balance checker Apr 3, 2025

notJoon added 3 commits April 4, 2025 00:42

fix

cb9a437

use mux

8efad65

fix

468a717

alexiscolin mentioned this pull request Apr 7, 2025

feat(gnoweb): form - input md extension #4061

Open

thehowl mentioned this pull request Apr 8, 2025

[Native Banker] Implement TotalCoin #2662

Open

Kouteki requested a review from moul April 14, 2025 07:25

Merge branch 'master' into airdrop-checker

7b5d23e

leohhhn self-requested a review April 14, 2025 18:18

notJoon added 3 commits April 16, 2025 16:22

start from the beginning

41ecdaf

simple r/coins

1978a90

disable totalsupply

b5893d6

notJoon and others added 3 commits April 16, 2025 17:10

Merge branch 'master' into airdrop-checker

f20a4d6

fmt

dc45336

Merge branch 'master' into airdrop-checker

b451b9a

moul approved these changes Apr 22, 2025

View reviewed changes

leohhhn approved these changes Apr 22, 2025

View reviewed changes

notJoon and others added 5 commits April 23, 2025 11:45

Update examples/gno.land/r/gnoland/coins/coins.gno

a357a08

Co-authored-by: Leon Hudak <[email protected]>

Apply suggestions from code review

c1b246d

Co-authored-by: Leon Hudak <[email protected]>

fix

16ed599

remove unnecessary package

b713afd

Merge branch 'master' into airdrop-checker

1398f4f

notJoon requested a review from leohhhn April 23, 2025 03:12

	func TotalSupply(banker std.Banker, denom string) int64 {
	func TotalSupply(denom string) int64 {

		[Back to Coin Info](/r/gnoland/coins:` + denom + `)
		[Back to Home](/r/gnoland/coins:)

feat: r/coins balance checker #3899

Are you sure you want to change the base?

feat: r/coins balance checker #3899

Conversation

notJoon commented Mar 10, 2025 • edited Loading

Description

Related

Gno2D2 commented Mar 10, 2025 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Then

If

Can be checked by

codecov bot commented Mar 10, 2025 • edited Loading

Codecov Report

leohhhn commented Mar 10, 2025

moul commented Mar 10, 2025

Choose a reason for hiding this comment

notJoon Mar 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moul Mar 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moul left a comment

Choose a reason for hiding this comment

notJoon commented Apr 14, 2025

moul commented Apr 14, 2025

notJoon commented Apr 14, 2025

moul commented Apr 14, 2025 • edited Loading

notJoon commented Apr 16, 2025

leohhhn left a comment

Choose a reason for hiding this comment

leohhhn Apr 22, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

notJoon Apr 23, 2025 • edited Loading

Choose a reason for hiding this comment

feat: `r/coins` balance checker #3899

feat: `r/coins` balance checker #3899

notJoon commented Mar 10, 2025 •

edited

Loading

Gno2D2 commented Mar 10, 2025 •

edited

Loading

codecov bot commented Mar 10, 2025 •

edited

Loading

notJoon Mar 11, 2025 •

edited

Loading

moul Mar 10, 2025 •

edited

Loading

moul commented Apr 14, 2025 •

edited

Loading

leohhhn Apr 22, 2025 •

edited

Loading

notJoon Apr 23, 2025 •

edited

Loading