Skip to content

feat: r/coins balance checker #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
May 9, 2025
Merged

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Mar 10, 2025

Description

Implemented the token inquiry function. Currently, only the feature to check coins at a specific address is provided, and the function to check the total quantity is not yet supported.

Example Usage:

  • /r/gnoland/coins:ugnot - shows the total supply of ugnot
  • /r/gnoland/coins:ugnot/g1... - shows the ugnot balance of a specific address

Related

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Mar 10, 2025
@Gno2D2 Gno2D2 requested a review from a team March 10, 2025 04:21
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Mar 10, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: notJoon/gno-core)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 And
            ├── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
            └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/tests/stdlibs/std/std.go 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Mar 10, 2025
@Kouteki Kouteki moved this from Triage to In Progress in 🧙‍♂️gno.land core team Mar 10, 2025
@leohhhn
Copy link
Contributor

leohhhn commented Mar 10, 2025

If you add TotalSupply in this PR, just linking this PR as well for the docs: #2661

@moul
Copy link
Member

moul commented Mar 10, 2025

can we stop using the term "airdrop" for this feature (PR title, and a unit test having the term in the title); this PR isn't an airdrop checker, but a balance checker.

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments.

@notJoon
Copy link
Member Author

notJoon commented Apr 16, 2025

@moul I've made modifications like this, what do you think? I've modified it to exclude the total supply and only provide the balance inquiry function for specific addresses.

1978a90

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; we can make the rendering better in the next iteration.

@notJoon notJoon requested a review from leohhhn April 23, 2025 03:12
@Kouteki
Copy link
Contributor

Kouteki commented Apr 28, 2025

If Jae can't review this PR by EOD, let's merge it tomorrow.

We've reduced complexity, there shouldn't be anything in it that can't be rolled back easily.

Copy link
Contributor

@jaekwon jaekwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kouteki Kouteki removed the don't merge Please don't merge this functionality temporarily label Apr 29, 2025
@thehowl thehowl merged commit 52bed78 into gnolang:master May 9, 2025
66 of 67 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 🧙‍♂️gno.land core team May 9, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx May 9, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🤝🏻 Partner: Onbloc May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants