fix: count gas for TypedValue.Sprint and println #3921
Closed
+421
−314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
added this to
🧙♂️gno.land core team and 💪 Bounties & Worx
github-actions
bot
added
📦 🤖 gnovm
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
ltzmaxwell
reviewed
Mar 17, 2025
|
also related: #3819. |
odeke-em
reviewed
Mar 21, 2025
|
|
||
| func (av *ArrayValue) ProtectedString(m *Machine, seen *seenValues) string { | ||
| defer func() { | ||
| // 7 characters for the array itself |
There was a problem hiding this comment.
I don't follow where the value 7 comes from. What's the rationale? It seems like a magic number.
There was a problem hiding this comment.
The return line array[]
ltzmaxwell
reviewed
Mar 28, 2025
Comment on lines
103
to
+107
| ss := make([]string, len(av.List)) | ||
| if av.Data == nil { | ||
| for i, e := range av.List { | ||
| ss[i] = e.ProtectedString(seen) | ||
| m.GasMeter.ConsumeGas(OpCPUAssign, CPUCYCLES) | ||
| ss[i] = e.ProtectedString(m, seen) |
There was a problem hiding this comment.
What is the purpose of this consumption? The elements should be consumed during their own visit.
There was a problem hiding this comment.
We have an assignement at the line below. Shouldn't we charge for it?
| } | ||
| // NOTE: we may want to unify the representation, | ||
| // but for now tests expect this to be different. | ||
| // This may be helpful for testing implementation behavior. | ||
| m.GasMeter.ConsumeGas(OpCPUAssign, CPUCYCLES) |
There was a problem hiding this comment.
I’m not sure we should call .ConsumeGas in so many places.
thehowl
changed the title
|
Can we add a test to verify that gas is counted properly? |
github-project-automation
bot
moved this from In Review
to Done
in 🧙♂️gno.land core team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 3816