feat(gnovm): interrealm spec; cross/crossing; readonly; defer/recover/panic fixes; blank identifier fixes....

gnovm/README.md

@@ -21,3 +21,7 @@ This enables non-web3 developers to contribute without requiring an understandin
 Install [`gno`](./cmd/gno) and refer to the [`examples`](../examples) folder to start developing contracts.
 
 Check the [Makefile](./Makefile) to enhance GnoVM, Gnolang, and stdlibs.
+
+## Known Issues
+
+* Switch varnames cannot be captured as heap items. [test](../gnovm/tests/files/closure11_known.gno)

gnovm/pkg/gnolang/files_test.go

@@ -73,6 +73,13 @@ func TestFiles(t *testing.T) {
 			})
 			return nil
 		}
+		isKnown := strings.HasSuffix(path, "_known.gno")
+		if isKnown {
+			t.Run(subTestName, func(t *testing.T) {
+				t.Skip("skipping known issue")
+			})
+			return nil
+		}
 
 		content, err := fs.ReadFile(fsys, path)
 		if err != nil {

gnovm/pkg/gnolang/machine.go

@@ -1671,7 +1671,7 @@
 
 // Returns a slice of n values in the stack and decrements NumValues.
 // NOTE: The results are on the values stack, so they must be copied or used
-// immediately.  If you need to use the machine before or during usage,
+// immediately. If you need to use the machine before or during usage,
 // consider using PopCopyValues().
 // NOTE: the values are in stack order, oldest first, the opposite order of
 // multiple pop calls.  This is used for params assignment, for example.
@@ -1686,12 +1686,13 @@
 	return m.Values[m.NumValues : m.NumValues+n]
 }
 
-// Like PopValues(), but copies the values onto a new slice.
-func (m *Machine) PopCopyValues(n int) []TypedValue {
-	res := make([]TypedValue, n)
+// Like PopValues(), but copies the values onto given slice.
+func (m *Machine) PopCopyValues(res []TypedValue) {
+	n := len(res)
 	ptvs := m.PopValues(n)
-	copy(res, ptvs)
-	return res
+	for i := 0; i < n; i++ {
+		res[i] = ptvs[i].Copy(m.Alloc)
+	}
 }
 
 // Decrements NumValues by number of last results.
@@ -2074,7 +2075,7 @@
 // Returns ro = true if the base is readonly,
 // or if the base's storage realm != m.Realm and both are non-nil,
 // and the lx isn't a name (base is a block),
 // and the lx isn't a composit lit expr.
 func (m *Machine) PopAsPointer2(lx Expr) (pv PointerValue, ro bool) {
 	switch lx := lx.(type) {
 	case *NameExpr:
@@ -2152,6 +2153,8 @@
 	}
 }
 
+// This function does not go-panic:
+// caller must return manually.
 func (m *Machine) Panic(ex TypedValue) {
 	m.Exceptions = append(
 		m.Exceptions,
@@ -2186,9 +2189,10 @@
 	// If the frame the exception occurred in is not popped, it's possible that
 	// the exception is still in scope and can be recovered.
 	if !exception.Frame.Popped {
-		// If the frame is not the current frame, the exception is not in scope; return nil.
-		// This retrieves the second most recent call frame because the first most recent
-		// is the call to recover itself.
+		// If the frame is not the current frame, the exception is not
+		// in scope; return nil.  This retrieves the second most recent
+		// call frame because the first most recent is the call to
+		// recover itself.
 		if frame := m.PeekCallFrame(2); frame == nil || frame != exception.Frame {
 			return nil
 		}