feat(examples): pokemon fight simulator game at `r/leo/pokemon` #4072

Tchips46 · 2025-04-07T17:04:11Z

Added

Realms:

r/leo/pokemon
A small Pokémon fight simulator game to showcase what a ranked game could look like using blockchain.

r/leo/home
idk

Pures:

p/leo/randomizer – A simplified math/rand. This is a temporary solution and will be removed once its issues are resolved.
p/leo/utils – A collection of useful functions for Gno development.
p/leo/dao – A basic and easily reusable dao system.
~~p/leo/renderer – A markdown library for features not implemented by p/moul/md, such as parameterized headers or table rendering.~~

Gno2D2 · 2025-04-07T17:05:29Z

🛠 PR Checks Summary

🔴 Pending initial approval by a review team member, or review from tech-staff

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: Tchips46/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🔴 Requirement not satisfied
└── 🔴 If
    ├── 🔴 Condition
    │   └── 🔴 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🔴 Else
        └── 🔴 And
            ├── 🟢 This label is applied to pull request: review/triage-pending
            ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
            └── 🔴 On no pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])
Can be checked by

team core-contributors

codecov · 2025-04-07T17:42:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

leohhhn

leaving some comments

leohhhn · 2025-04-15T13:49:56Z

examples/gno.land/r/leo/home/home.gno

Since this is quite small, i suggest you deploy this permissionlessly :)

leohhhn · 2025-04-15T13:58:14Z

examples/gno.land/r/leo/pokemon/render_selector.gno

+	pokemonPath = map[RenderPage]func(map[string]string) string{
+		pokemonLogin:        renderPokemonLogin,
+		pokemonLobby:        renderPokemonLobby,
+		pokemonTeamSelector: renderPokemonTeam,
+		pokemonFight:        renderPokemonFight,
+		pokemonShop:         renderPokemonShop,
+		pokemonRank:         renderPokemonRank,
+	}
+)
+
+func Render(path string) (rend string) {
+	rend += md.H1("Pokémon")
+	path, params := utils.ParsePath(path)
+
+	if pathRenderer := pokemonPath[RenderPage(path)]; pathRenderer != nil && pokemonDAO.IsMember(std.Address(params["user"])) {
+		rend += pathRenderer(params)
+	} else {
+		rend += renderPokemonLogin(params)
+	}
+	return
+}


This is a cool approach, but I suggest using one of the libraries we have for routing, such as the p/demo/mux library, which is more go-like :)

this library also provides a simple way to get query parameters. check out https://gno.land/r/docs/routing

leohhhn · 2025-04-15T13:58:22Z

examples/gno.land/r/leo/pokemon/render_selector.gno

+
+var (
+	rand        = randomizer.NewRandomizer()
+	nl          = "\n\n"


can be const as well

Done ! a6ca485

leohhhn · 2025-04-15T14:00:01Z

examples/gno.land/r/leo/pokemon/login.gno

+	for i, e := range pokemonDAO.userData {
+		link := atm_path + ":" + string(pokemonLobby) + "?user=" + string(pokemonDAO.GetMembers()[i])
+		rend += " - " + md.Link(string(pokemonDAO.GetMembers()[i]), link)
+		rend += " : " + renderPokedollar(int(e.pokedollar)) + nl
+	}
+	return


could be nice to use r/sys/users :)

check out https://gno.land/r/docs/use_rsysusers

leohhhn · 2025-04-15T15:47:36Z

Also please check the CI!

…m-pokemon-game-for-demo

github-project-automation bot added this to 🧙‍♂️gno.land core team and 💪 Bounties & Worx Apr 7, 2025

github-project-automation bot moved this to Triage in 🧙‍♂️gno.land core team Apr 7, 2025

Tchips46 marked this pull request as draft April 7, 2025 17:04

github-actions bot assigned Tchips46 Apr 7, 2025

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Apr 7, 2025

Gno2D2 requested a review from a team April 7, 2025 17:05

Tchips46 mentioned this pull request Apr 7, 2025

Leo's Builder Journey gnolang/hackerspace#115

Open

leohhhn added this to 🧑‍🎓Student contributors Apr 9, 2025

leohhhn moved this to In Progress in 🧑‍🎓Student contributors Apr 9, 2025

Tchips46 added 4 commits April 10, 2025 11:20

feat(examples): leo's home and pokemon fight simulator game

888418d

feat: basic and extendable dao

88b15a4

fix: type asser -> assert

03c6b58

feat(examples): pokemon fight

6be7a81

Tchips46 force-pushed the feat/add-leo-realm-pokemon-game-for-demo branch from 14b4c01 to 6be7a81 Compare April 14, 2025 14:22

Tchips46 added 2 commits April 14, 2025 20:36

feat(examples): ranking system

5a86960

feat(examples): new pokemons and format fix

5eb56d6

Tchips46 marked this pull request as ready for review April 15, 2025 12:04

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Apr 15, 2025

leohhhn reviewed Apr 15, 2025

View reviewed changes

Tchips46 added 5 commits April 16, 2025 11:13

Merge remote-tracking branch 'upstream/master' into feat/add-leo-real…

d2dc5c1

…m-pokemon-game-for-demo

fix(examples): rename hof to hor

e9d7f34

fix(examples): make new line variable constant

a6ca485

fix(example/pokemon): use mux for render ditribution

5d8f827

fix(examples/pokemon): show username from sys/users

a5a0ae2

Tchips46 requested a review from leohhhn April 16, 2025 12:22

fix(examples/pokemon): replace image from new ones comming from github

63efb87

Kouteki removed this from 🧙‍♂️gno.land core team Apr 17, 2025

Kouteki removed the request for review from a team April 17, 2025 07:05

Tchips46 added 2 commits April 17, 2025 18:50

feat(example/dao): dao tests

5fa4ea4

feat(examples): utils tests

f5cab9e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(examples): pokemon fight simulator game at `r/leo/pokemon` #4072

feat(examples): pokemon fight simulator game at `r/leo/pokemon` #4072

Tchips46 commented Apr 7, 2025 •

edited

Loading

Gno2D2 commented Apr 7, 2025 •

edited

Loading

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

codecov bot commented Apr 7, 2025

leohhhn left a comment

leohhhn Apr 15, 2025

leohhhn Apr 15, 2025

leohhhn Apr 15, 2025

Tchips46 Apr 16, 2025

leohhhn Apr 15, 2025

Tchips46 Apr 16, 2025

leohhhn Apr 15, 2025

Tchips46 Apr 16, 2025

leohhhn commented Apr 15, 2025

feat(examples): pokemon fight simulator game at r/leo/pokemon #4072

Are you sure you want to change the base?

feat(examples): pokemon fight simulator game at r/leo/pokemon #4072

Conversation

Tchips46 commented Apr 7, 2025 • edited Loading

Added

Realms:

Pures:

Gno2D2 commented Apr 7, 2025 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

codecov bot commented Apr 7, 2025

Codecov Report

leohhhn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leohhhn commented Apr 15, 2025

feat(examples): pokemon fight simulator game at `r/leo/pokemon` #4072

feat(examples): pokemon fight simulator game at `r/leo/pokemon` #4072

Tchips46 commented Apr 7, 2025 •

edited

Loading

Gno2D2 commented Apr 7, 2025 •

edited

Loading