feat(examples): DAO to propose polls and vote #4082
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
added this to
🧙♂️gno.land core team and 💪 Bounties & Worx
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
leohhhn
reviewed
Apr 14, 2025
Comment on lines
+34
to
+49
| func ParseQuery(path string) (daoID string, showStats bool) { | ||
| parts := strings.Split(path, "?") | ||
| if len(parts) < 2 { | ||
| return "", false | ||
| } | ||
|
|
||
| args := strings.Split(parts[1], "&") | ||
| for _, arg := range args { | ||
| if strings.HasPrefix(arg, "dao=") { | ||
| daoID = arg[len("dao="):] | ||
| } else if arg == "stats" { | ||
| showStats = true | ||
| } | ||
| } | ||
| return | ||
| } |
There was a problem hiding this comment.
this package seems like general utils package, but then you see that it's actually not, as it has things replated to your specific app. When you separate code like this, it also makes sense to think about how other people might use your code.
In this case, I have two things to say:
- maybe this utils package should be under
r/moonia/home/utils, or/internal - for handling queries and paths, you can use the
p/demo/muxpackage. Check this tutorial out: https://gno.land/r/docs/routing
Comment on lines
+8
to
+44
| // Admin Methods // | ||
|
|
||
| func IsAdmin(addr std.Address) bool { | ||
| return ds.DAO.IsAdmin(addr) | ||
| } | ||
|
|
||
| func SetAdmin() string { | ||
| return ds.DAO.SetAdmin() | ||
| } | ||
|
|
||
| func TransferAdmin(addr std.Address) string { | ||
| return ds.DAO.TransferAdmin(addr) | ||
| } | ||
|
|
||
| func KickMember(addr std.Address) string { | ||
| return ds.DAO.KickMember(addr) | ||
| } | ||
|
|
||
| func AddMember(addr std.Address) string { | ||
| return ds.DAO.AddMember(addr) | ||
| } | ||
|
|
||
| func ListMembers() map[std.Address]bool { | ||
| return ds.DAO.Whitelist | ||
| } | ||
|
|
||
| func AcceptRequest(addr std.Address) string { | ||
| return ds.DAO.AcceptRequest(addr) | ||
| } | ||
|
|
||
| func DeclineRequest(addr std.Address) string { | ||
| return ds.DAO.DeclineRequest(addr) | ||
| } | ||
|
|
||
| func ListRequests() map[std.Address]bool { | ||
| return ds.DAO.ListRequests() | ||
| } |
There was a problem hiding this comment.
This is a lot of boilerplate code. Check out the safe object examples such as ownable, and try to make a top-level struct that is safe to expose, and also automatically gives you the getters and setters you need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple DAO that allows members to create polls (proposals) and vote on them.
Add the following:
Realms:
r/moonia/home: Renders the DAO dashboard listing all existing DAOs and exposes user-facing actions.p/moonia/utils: Provides helper functions for caller identification and safe index parsingPure:
p/moonia/dao: Core logic of the DAO. Includes membership, proposal creation and deletion, voting.p/moonia/admin: Manage admin rights and actions.I'm also looking for suggestions on file organization. 🚀