feat(example): calculator realm #4084

NicolasMelet · 2025-04-09T08:51:02Z

This calculator realm implements a binary tree to compute the result of mathematics expressions.

Make basic computation possible (+ - / * and decimals)
store computation functions in a map as lambda
write tests
add parenthesis in equation

Gno2D2 · 2025-04-09T08:52:21Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: NicolasMelet/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 And
            ├── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
            └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])
Can be checked by

team core-contributors

…idity

NicolasMelet · 2025-04-14T11:09:29Z

examples/gno.land/r/miko/calculator/calculator.gno

+		"*": func(left float64, right float64) float64 { return left * right },
+		"/": func(left float64, right float64) float64 {
+			if right == 0 {
+				panic("Division by 0 is forbidden")


The 0 division can only be detected when reading the tree, and I don't see a way of properly handling this case that doesn't involve a weird third parameter for all operation function, or a global variable

leohhhn

left a couple of comments. nice work :)

leohhhn · 2025-04-14T14:04:36Z

examples/gno.land/r/miko/home/home.gno

+	return out
+}
+
+func RenderPassion() string {


these can be unexported

7787495
Done !

leohhhn · 2025-04-14T14:05:14Z

examples/gno.land/r/miko/calculator/calculator_test.gno

+import "testing"
+
+func TestCounter_Addition(t *testing.T) {
+


remove these newlines :)

9aaa711
Done !

leohhhn · 2025-04-14T14:05:49Z

examples/gno.land/r/miko/calculator/calculator.gno

+Result: ` + displayVal + `
+---------------
+| ` + ufmt.Sprintf("[res](%s)", realmPath) + `| ` + ufmt.Sprintf("[(](%s)", realmPath+":?expression="+expression+"<") + `| ` + ufmt.Sprintf("[)](%s)", realmPath+":?expression="+expression+">") + `| ` + ufmt.Sprintf("[del](%s)", realmPath+":?expression="+removeLast(expression)) + `|
+|---|---|---|---|
+| ` + ufmt.Sprintf("[7](%s)", realmPath+":?expression="+expression+"7") + `| ` + ufmt.Sprintf("[8](%s)", realmPath+":?expression="+expression+"8") + `| ` + ufmt.Sprintf("[9](%s)", realmPath+":?expression="+expression+"9") + `| ` + ufmt.Sprintf("[+](%s)", realmPath+":?expression="+expression+"p") /* here p replaces + because of how + works in bnormal paths*/ + `|
+| ` + ufmt.Sprintf("[4](%s)", realmPath+":?expression="+expression+"4") + `| ` + ufmt.Sprintf("[5](%s)", realmPath+":?expression="+expression+"5") + `| ` + ufmt.Sprintf("[6](%s)", realmPath+":?expression="+expression+"6") + `| ` + ufmt.Sprintf("[-](%s)", realmPath+":?expression="+expression+"-") + `|
+| ` + ufmt.Sprintf("[1](%s)", realmPath+":?expression="+expression+"1") + `| ` + ufmt.Sprintf("[2](%s)", realmPath+":?expression="+expression+"2") + `| ` + ufmt.Sprintf("[3](%s)", realmPath+":?expression="+expression+"3") + `| ` + ufmt.Sprintf("[*](%s)", realmPath+":?expression="+expression+"*") + `|
+| ` + ufmt.Sprintf("[0](%s)", realmPath+":?expression="+expression+"0") + `| ` + ufmt.Sprintf("[.](%s)", realmPath+":?expression="+expression+".") + `| ` + ufmt.Sprintf("[=](%s)", realmPath+":?expression="+expression+"=") + `| ` + ufmt.Sprintf("[/](%s)", realmPath+":?expression="+expression+"/") + `|
+`)


Try out a library for this, such as p/moul/md

I have used this library for the mardown, but for the columns it isn't exactly what I need as the Columns() function always put "|||' between each column, which gives another display than simply "|"

Oh sorry, i meant p/moul/mdtable :)

e10b516
Done !

leohhhn · 2025-04-14T14:11:27Z

examples/gno.land/r/miko/calculator/calculator.gno

+Have you ever wanted to do maths but never actually found a calculator ?
+Do I have the realm for you...


leohhhn · 2025-04-14T14:13:22Z

examples/gno.land/r/miko/calculator/calculator.gno

+}
+
+func Render(path string) string {
+	var sb strings.Builder


I prefer doing out:= "" simply for readability

ffeae14
Done !

leohhhn · 2025-04-15T10:59:56Z

Also, please check why the CI is failing

codecov · 2025-04-15T11:05:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

NicolasMelet · 2025-04-16T08:13:38Z

Also, please check why the CI is failing

Is it not because there need to be a positive review ?

jefft0 · 2025-04-16T08:37:56Z

Also, please check why the CI is failing

Is it not because there need to be a positive review ?

Yes, that's right. It's normal for the "Merge Requirements" CI to fail while waiting for a review from a core team member.

notJoon

LGTM

remove: review/triage-pending flag

thehowl · 2025-04-17T09:18:23Z

examples/gno.land/r/miko/calculator/calculator.gno

+}
+
+const (
+	specialCharacters             = "p-*/."


why not +? (it should be fine as long as it's url-encoded)

It seems like
query.Get("expression")

removes the '+'

I have tried printing the path given by Render and the expression obtained via query.Get

path : ?expression=4+

expression : 4

Still the solution of using req.String allowed me to use '(' and ')' instead of '<' and '>' !

c34cbf4

thehowl · 2025-04-17T09:24:59Z

examples/gno.land/r/miko/calculator/calculator.gno

+	table.Append([]string{md.Link("7", realmPath+":?expression="+expression+"7"), md.Link("8", realmPath+":?expression="+expression+"8"), md.Link("9", realmPath+":?expression="+expression+"9"), md.Link("+", realmPath+":?expression="+expression+"p")})
+	table.Append([]string{md.Link("4", realmPath+":?expression="+expression+"4"), md.Link("5", realmPath+":?expression="+expression+"5"), md.Link("6", realmPath+":?expression="+expression+"6"), md.Link("-", realmPath+":?expression="+expression+"-")})
+	table.Append([]string{md.Link("1", realmPath+":?expression="+expression+"1"), md.Link("2", realmPath+":?expression="+expression+"2"), md.Link("3", realmPath+":?expression="+expression+"3"), md.Link("*", realmPath+":?expression="+expression+"*")})
+	table.Append([]string{md.Link("0", realmPath+":?expression="+expression+"0"), md.Link(".", realmPath+":?expression="+expression+"."), md.Link("=", realmPath+":?expression="+expression+"="), md.Link("/", realmPath+":?expression="+expression+"/")})


line = make([]string, 0, 3) for idx, c := range "7894561230.=/" { query.Set("expression", expression + c) line = append(line, md.Link(string(c), req.String())) if len(line) == 3 { table.Append(line) line = line[:0] } }

I had to change the way line is reset here. I'm not 100% confident in gno or go yet, but it seemed like resetting it this way only reseted the index of the []string like a pointer, making it so that every line had the same few characters (. = / here)
instead I assigned a new array to line
line = []string{}

is this a good way to handle this situation in gno ?

c34cbf4

thehowl

You can use ( ) and + in query strings if you use realmpath, because its string method will encode the characters and make them not special.

feat: add calculator and home realm

9b9492a

github-project-automation bot added this to 🧙‍♂️gno.land core team and 💪 Bounties & Worx Apr 9, 2025

github-project-automation bot moved this to Triage in 🧙‍♂️gno.land core team Apr 9, 2025

github-actions bot assigned NicolasMelet Apr 9, 2025

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Apr 9, 2025

Gno2D2 requested a review from a team April 9, 2025 08:52

NicolasMelet mentioned this pull request Apr 9, 2025

NicolasMelet's Builder Journey gnolang/hackerspace#116

Open

leohhhn changed the title ~~feat(exemple): calculator realm~~ feat(example): calculator realm Apr 9, 2025

leohhhn self-requested a review April 9, 2025 09:42

NicolasMelet added 5 commits April 10, 2025 17:09

feat: changed txlink for path querry, compute still in progress

354b409

feat: computation now works again, app fully handled with path

69c4861

clean: removed useless variable and added documentation

e330d9c

feat: added unit tests

345cc21

fix: changed panick errors to standart error handling for evaluateVal…

8cd3d2a

…idity

NicolasMelet commented Apr 14, 2025

View reviewed changes

feat: parenthesis now available

44cb487

leohhhn reviewed Apr 14, 2025

View reviewed changes

NicolasMelet and others added 7 commits April 14, 2025 17:38

feat: handle negative values + added tests

f7ebebc

Merge branch 'master' into master

c7b7ad9

fix: unexport render functions

7787495

clean: removed newlines in tests

9aaa711

clean: use out string instead of strings builder

ffeae14

clean: use md package for markdown

def6b5c

Merge branch 'master' into master

09209d1

NicolasMelet marked this pull request as ready for review April 15, 2025 09:52

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Apr 15, 2025

Merge branch 'master' into master

c566b19

clean: used mdtable package

e10b516

leohhhn moved this to In Progress in 🧑‍🎓Student contributors Apr 16, 2025

leohhhn added this to 🧑‍🎓Student contributors Apr 16, 2025

leohhhn self-requested a review April 16, 2025 09:21

NicolasMelet and others added 2 commits April 16, 2025 11:51

chore: remove home realm

7df0d90

Merge branch 'master' into master

d529ff5

notJoon approved these changes Apr 17, 2025

View reviewed changes

notJoon removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Apr 17, 2025

Kouteki removed this from 🧙‍♂️gno.land core team Apr 17, 2025

Kouteki removed the request for review from a team April 17, 2025 07:16

Merge branch 'master' into master

8a1f4e7

Gno2D2 requested a review from a team April 17, 2025 08:38

thehowl reviewed Apr 17, 2025

View reviewed changes

NicolasMelet and others added 3 commits April 17, 2025 16:38

fix: parenthesis can appear in url + cleanup table making in code

c34cbf4

Merge branch 'master' into master

99fd13f

Merge branch 'master' into master

2749424

NicolasMelet requested a review from thehowl April 18, 2025 13:07

		Have you ever wanted to do maths but never actually found a calculator ?
		Do I have the realm for you...

feat(example): calculator realm #4084

Are you sure you want to change the base?

feat(example): calculator realm #4084

Conversation

NicolasMelet commented Apr 9, 2025 • edited Loading

Gno2D2 commented Apr 9, 2025 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

Choose a reason for hiding this comment

leohhhn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leohhhn commented Apr 15, 2025

codecov bot commented Apr 15, 2025

Codecov Report

NicolasMelet commented Apr 16, 2025

jefft0 commented Apr 16, 2025

notJoon left a comment

Choose a reason for hiding this comment

thehowl Apr 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thehowl Apr 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thehowl left a comment

Choose a reason for hiding this comment

NicolasMelet commented Apr 9, 2025 •

edited

Loading

Gno2D2 commented Apr 9, 2025 •

edited

Loading

thehowl Apr 17, 2025 •

edited

Loading

thehowl Apr 17, 2025 •

edited

Loading