Skip to content

feat(gnovm): simplify redundant conversions #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

feat(gnovm): simplify redundant conversions #4131

merged 2 commits into from
Apr 16, 2025

Conversation

petar-dambovaliev
Copy link
Contributor

Closes 4119

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Apr 13, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@odeke-em
Copy link
Contributor

Thanks for the fix @petar-dambovaliev! If possible, adding a regression test to lock-in this behaviour would be super useful in case something changes in the future, otherwise it'll be impossible to detect the breakage. Thank you.

@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️gno.land core team Apr 14, 2025
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Apr 15, 2025
@Gno2D2 Gno2D2 requested a review from a team April 15, 2025 22:33
@thehowl thehowl changed the title feat: optimize unnecessary conversions feat(gnovm): simplify redundant conversions Apr 16, 2025
@thehowl thehowl merged commit a6b091a into master Apr 16, 2025
68 checks passed
@thehowl thehowl deleted the 4119 branch April 16, 2025 14:04
@github-project-automation github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Optimize away useless conversions
4 participants