feat(ufmt): enhance printf functionnalities by adding flags #4136

paulogarithm · 2025-04-14T14:51:35Z

Fixes

ufmt/printf
- added flag parsing, such as %.number, %#, %0, and others
- cf 5d71b3a
- new features has been tested using unit tests (see tests)

* includes gnominers * includes home * include pure packages

* reorganise gnominers into submodules * create the dao submodule * add the tofix folder with all broken features * create the minerdao /!\ DAO DOESNT WORK RN BECAUSE OF CYCLE DEPENDANCIES /!\

* i didnt use subfolders

* add precisision flag ("%.2f") * add 0 & ' ' flags ("%03d", "% 3d") * add length parsing (not used rn) * add # for hex ("%#02x") * add %i & %X (%i is just %d, %X is big hex) * change the home * ass some tests to handle what ive done

* also changed my home page so it displays a number

Format -> FormatRound because it rounds...

* cause of major issue because it was reading to far

* better messages * better formatting * use `p/moun/md` for md formatting in users.gno

paulogarithm · 2025-04-14T14:58:57Z

@thehowl done

codecov · 2025-04-14T15:19:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

notJoon

I've left a few comments. I would appreciate if you could check them 👍

examples/gno.land/p/demo/ufmt/ufmt.gno

Co-authored-by: Lee ByeongJun <[email protected]>

* fix oldLen and oldString that was stored and not updated in the precision changed, so it was checking the old string instead of the fresh new one * added tests to handle the special case of %.000000f

paulogarithm · 2025-04-15T09:30:03Z

@notJoon i'm done fixing everything 👍 i just need your opinion on something (concerning backward pointer checking usefullness)

paulogarithm · 2025-04-15T13:46:21Z

tell me if i need to add anything else !

notJoon

I've confirmed that all the requested changes have been reflected and all tests have passed.

It's a minor point related to policy, but the "resolve conversation" button should not be pressed until the reviewer has checked it. Please refer to this document for more details.

Anyway, except for this, everything else looks good.

remove: review/triage-pending flag

notJoon · 2025-04-16T10:26:54Z

@paulogarithm

Hmm... When using ufmt (especially, using Sprintf function), gas consumption increases causing "out of gas" errors and test failures. The other CI failure issues will likely be resolved with a branch update, but this one seems to require code modifications.

I'll check this problem today. If it's okay, may I modify this code together with you?

paulogarithm · 2025-04-16T16:30:06Z

totally fine for me, @notJoon ! but maybe it's because of the maps, so when you'll test, can you try putting the maps in the scope like i did, even if it's more greedy on memory ?

notJoon · 2025-04-17T00:56:05Z

can you try putting the maps in the scope like i did, even if it's more greedy on memory ?

I'm testing by directly checking the gas consumption with txtar. It seems rather than map usage, we also need to improve parts related to memory allocation within the ufmt package overall.

notJoon · 2025-04-17T02:27:53Z

@paulogarithm I couldn't push directly to this PR #4174, so I created a separate PR. Please check it and feel free to cherry-pick if needed. thank you 👍

gfanton

Nice ! this is something really welcome !

Could you please update documentation above Sprintf as well as indicating all currently supported flags ? (you can take inspiration from https://pkg.go.dev/fmt)

While we are here we could support padding as well ? (could be done in another PR)

I've tried your code against some go/fmt test code, and the output differs in many formatting cases.

		// advanced int (from go/fmt)
		{"%.d", []any{0}, ""},
		{"%.0d", []any{0}, ""},
		{"% d", []any{12345}, " 12345"},
		{"%+d", []any{12345}, "+12345"},
		{"%+d", []any{-12345}, "-12345"},
		{"%#X", []any{0}, "0X0"},
		{"%x", []any{0x12abcdef}, "12abcdef"},
		{"%X", []any{0x12abcdef}, "12ABCDEF"},
		{"%x", []any{^uint32(0)}, "ffffffff"},
		{"%X", []any{^uint64(0)}, "FFFFFFFFFFFFFFFF"},
		// {"%010d", []any{12345}, "0000012345"},
		// {"%010d", []any{-12345}, "-000012345"}, // weird behaviors

		// advanced float (from go/fmt)
		{"%+.3e", []any{0.0}, "+0.000e+00"},
		{"%+.3e", []any{1.0}, "+1.000e+00"},
		{"%+.3x", []any{0.0}, "+0x0.000p+00"},
		{"%+.3x", []any{1.0}, "+0x1.000p+00"},
		{"%+.3f", []any{-1.0}, "-1.000"},
		{"%+.3F", []any{-1.0}, "-1.000"},
		{"%+.3F", []any{float32(-1.0)}, "-1.000"},
		{"% .3E", []any{-1.0}, "-1.000E+00"},
		{"% .3e", []any{1.0}, " 1.000e+00"},
		{"% .3X", []any{-1.0}, "-0X1.000P+00"},
		{"% .3x", []any{1.0}, " 0x1.000p+00"},
		{"%+.3g", []any{0.0}, "+0"},
		{"%+.3g", []any{1.0}, "+1"},
		{"%+.3g", []any{-1.0}, "-1"},
		{"% .3g", []any{-1.0}, "-1"},
		{"% .3g", []any{1.0}, " 1"},
		// Test sharp flag used with floats.
		{"%#g", []any{1e-323}, "1.00000e-323"},
		{"%#g", []any{-1.0}, "-1.00000"},
		{"%#g", []any{1.1}, "1.10000"},
		{"%#g", []any{123456.0}, "123456."},
		{"%#g", []any{1234567.0}, "1.234567e+06"},
		{"%#g", []any{1230000.0}, "1.23000e+06"},
		{"%#g", []any{1000000.0}, "1.00000e+06"},
		{"%#.0f", []any{1.0}, "1."},
		{"%#.0e", []any{1.0}, "1.e+00"},
		{"%#.0x", []any{1.0}, "0x1.p+00"},
		{"%#.0g", []any{1.0}, "1."},
		{"%#.0g", []any{1100000.0}, "1.e+06"},
		{"%#.4f", []any{1.0}, "1.0000"},
		{"%#.4e", []any{1.0}, "1.0000e+00"},
		{"%#.4x", []any{1.0}, "0x1.0000p+00"},
		{"%#.4g", []any{1.0}, "1.000"},
		{"%#.4g", []any{100000.0}, "1.000e+05"},
		{"%#.4g", []any{1.234}, "1.234"},
		{"%#.4g", []any{0.1234}, "0.1234"},
		{"%#.4g", []any{1.23}, "1.230"},
		{"%#.4g", []any{0.123}, "0.1230"},
		{"%#.4g", []any{1.2}, "1.200"},
		{"%#.4g", []any{0.12}, "0.1200"},
		{"%#.4g", []any{10.2}, "10.20"},
		{"%#.4g", []any{0.0}, "0.000"},
		{"%#.4g", []any{0.012}, "0.01200"},
		{"%#.0f", []any{123.0}, "123."},
		{"%#.0e", []any{123.0}, "1.e+02"},
		{"%#.0x", []any{123.0}, "0x1.p+07"},
		{"%#.0g", []any{123.0}, "1.e+02"},
		{"%#.4f", []any{123.0}, "123.0000"},
		{"%#.4e", []any{123.0}, "1.2300e+02"},
		{"%#.4x", []any{123.0}, "0x1.ec00p+06"},
		{"%#.4g", []any{123.0}, "123.0"},
		{"%#.4g", []any{123000.0}, "1.230e+05"},

Even if minimalist, this library should follow the output of go/fmt to be consistent with Go behaviors. Don't hesitate to follow / copy the fmt library code in Go to match the behavior.

Also i got some weird behaviours from %010d with -12345 -> 0000-12345

I will also check the gas issue. Since many projects import this package, we should take extra precautions regarding performance, but please do not compromise readability.

gfanton · 2025-04-18T14:34:03Z

examples/gno.land/p/demo/ufmt/ufmt.gno

@@ -170,14 +295,14 @@ func (p *printer) doPrintf(format string, args []any) {
 			writeString(p, verb, arg)
 		case 'c':
 			writeChar(p, verb, arg)
-		case 'd':
+		case 'd', 'i':


%i doesn't seems to exist in go, I don't think we should port it in gno

gfanton · 2025-04-18T14:34:34Z

examples/gno.land/p/demo/ufmt/ufmt.gno

+// the different flags
+const (
+	flagHashtag uint8 = 1
+	flagZero    uint8 = 1 << 1
+	flagMinus   uint8 = 1 << 2
+	flagSpace   uint8 = 1 << 3
+	flagPlus    uint8 = 1 << 4
+)


Suggested change

// the different flags

const (

flagHashtag uint8 = 1

flagZero uint8 = 1 << 1

flagMinus uint8 = 1 << 2

flagSpace uint8 = 1 << 3

flagPlus uint8 = 1 << 4

)

// the different flags

const (

flagHashtag uint8 = 1 << iota

flagZero

flagMinus

flagSpace

flagPlus

)

gfanton · 2025-04-18T14:39:23Z

examples/gno.land/p/demo/ufmt/ufmt.gno

+	}
+	stop := false
+	for {
+		x, ok := c2f[runes[*index]]


Hiding the reference inside a map complicates readability and performance. Why not use a direct switch case like this:

switch *index { case '+' case '-': ... }

paulogarithm and others added 30 commits April 7, 2025 18:47

feat(examples): add 'pol' example page

502c85b

* includes gnominers * includes home * include pure packages

chore: remove the unusep p/pol/gnomining package

f72fd4c

feat(gnominers): nerf opal price & spawn rate

10c4960

Merge branch 'gnolang:master' into master

30780d2

feat(gnominers): begin dao impl in gnominers

d935be7

* reorganise gnominers into submodules * create the dao submodule * add the tofix folder with all broken features * create the minerdao /!\ DAO DOESNT WORK RN BECAUSE OF CYCLE DEPENDANCIES /!\

fix(gnominers): finish impl dao

966de11

* i didnt use subfolders

feat(gnominers): now you can generate a DAO request

4923018

fix(gnominers): bad formatting

80bf496

feat: add uufmt (with printf with flags) + nfmt (number format)

20260f7

Merge branch 'gnolang:master' into master

5455127

feat: add flag parsing in ufmt.printf

5d71b3a

* add precisision flag ("%.2f") * add 0 & ' ' flags ("%03d", "% 3d") * add length parsing (not used rn) * add # for hex ("%#02x") * add %i & %X (%i is just %d, %X is big hex) * change the home * ass some tests to handle what ive done

fix(nfmt): number format fix .2f instead of .1f

f396fe4

* also changed my home page so it displays a number

fix(nfmt): number format func name

a91aac5

Format -> FormatRound because it rounds...

fix(ufmt)!: flag parsing using []rune instead of string

efb7a3e

* cause of major issue because it was reading to far

feat(gnominers): add nfmt to shop

c5d0400

chore: remove tofix folder remotely

9451a3b

fix(gnolang#4109): html escape string global realm error

8289230

chore: add some gno-columns everywhere so its cleaner

f2359c8

feat(gnominers): add the leaderboard system

ce15ebf

feat(ux): improved user experience + use md lib

9755a09

* better messages * better formatting * use `p/moun/md` for md formatting in users.gno

feat(gnominers): change everything to use md lib

6decc3f

feat: add releases to gnominers

6b914d3

feat: implement gnominers releases in home

d83de10

chore: fixup render gno unused packages

6ea1081

feat(home): make my home page use md lib

76d2680

Merge branch 'master' into master

67b2a21

fix: remove uufmt

d172d78

test(ufmt/sprintf): add more tests to printf

feaffc2

feat(ufmt/printf): add %x features for []uint8{}

fd9e9fb

chore: remove r/pol & p/pol for clean PR

442a327

paulogarithm changed the title ~~feat(ufmt) & fix(#4109): enhance printf functionnalities by adding flags + fixing gnovm html escape issue~~ feat(ufmt): enhance printf functionnalities by adding flags Apr 14, 2025

Merge branch 'master' into ufmt-enhancement

2dc5f13

paulogarithm marked this pull request as ready for review April 14, 2025 15:08

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Apr 14, 2025

notJoon suggested changes Apr 15, 2025

View reviewed changes

github-project-automation bot moved this to In Progress in 💪 Bounties & Worx Apr 15, 2025

paulogarithm and others added 5 commits April 15, 2025 10:48

Update examples/gno.land/p/demo/ufmt/ufmt.gno

47b20da

Co-authored-by: Lee ByeongJun <[email protected]>

Update examples/gno.land/p/demo/ufmt/ufmt.gno

a9633ce

Co-authored-by: Lee ByeongJun <[email protected]>

chore: formatting & typos

53a20d1

fix: increase index pointer not based on number size

b6c03bf

feat: ptrForward to safely move forward + fix! (see comment)

d79fd53

* fix oldLen and oldString that was stored and not updated in the precision changed, so it was checking the old string instead of the fresh new one * added tests to handle the special case of %.000000f

chore: move map to upvalues for better memory efficiency

6353239

notJoon approved these changes Apr 16, 2025

View reviewed changes

notJoon removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Apr 16, 2025

leohhhn removed this from 💪 Bounties & Worx Apr 16, 2025

leohhhn added this to 🧑‍🎓Student contributors Apr 16, 2025

leohhhn moved this to In Progress in 🧑‍🎓Student contributors Apr 16, 2025

leohhhn moved this from In Progress to In Review in 🧑‍🎓Student contributors Apr 16, 2025

fix: remove test on leon's home

1d29c1c

notJoon mentioned this pull request Apr 17, 2025

feat(p/ufmt): Optimize ufmt package #4174

Draft

Kouteki moved this from Triage to In Review in 🧙‍♂️gno.land core team Apr 17, 2025

gfanton requested changes Apr 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ufmt): enhance printf functionnalities by adding flags #4136

feat(ufmt): enhance printf functionnalities by adding flags #4136

paulogarithm commented Apr 14, 2025 •

edited

Loading

paulogarithm commented Apr 14, 2025

codecov bot commented Apr 14, 2025

notJoon left a comment

paulogarithm commented Apr 15, 2025

paulogarithm commented Apr 15, 2025

notJoon left a comment •

edited

Loading

notJoon commented Apr 16, 2025 •

edited

Loading

paulogarithm commented Apr 16, 2025 •

edited

Loading

notJoon commented Apr 17, 2025 •

edited

Loading

notJoon commented Apr 17, 2025 •

edited

Loading

gfanton left a comment •

edited

Loading

gfanton Apr 18, 2025

gfanton Apr 18, 2025

gfanton Apr 18, 2025

feat(ufmt): enhance printf functionnalities by adding flags #4136

Are you sure you want to change the base?

feat(ufmt): enhance printf functionnalities by adding flags #4136

Conversation

paulogarithm commented Apr 14, 2025 • edited Loading

Fixes

paulogarithm commented Apr 14, 2025

codecov bot commented Apr 14, 2025

Codecov Report

notJoon left a comment

Choose a reason for hiding this comment

paulogarithm commented Apr 15, 2025

paulogarithm commented Apr 15, 2025

notJoon left a comment • edited Loading

Choose a reason for hiding this comment

notJoon commented Apr 16, 2025 • edited Loading

paulogarithm commented Apr 16, 2025 • edited Loading

notJoon commented Apr 17, 2025 • edited Loading

notJoon commented Apr 17, 2025 • edited Loading

gfanton left a comment • edited Loading

Choose a reason for hiding this comment

gfanton Apr 18, 2025

Choose a reason for hiding this comment

gfanton Apr 18, 2025

Choose a reason for hiding this comment

gfanton Apr 18, 2025

Choose a reason for hiding this comment

paulogarithm commented Apr 14, 2025 •

edited

Loading

notJoon left a comment •

edited

Loading

notJoon commented Apr 16, 2025 •

edited

Loading

paulogarithm commented Apr 16, 2025 •

edited

Loading

notJoon commented Apr 17, 2025 •

edited

Loading

notJoon commented Apr 17, 2025 •

edited

Loading

gfanton left a comment •

edited

Loading