Skip to content

fix: properly set the govDAO implementation on the v3/impl realm #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

ajnavarro
Copy link
Contributor

No description provided.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Apr 15, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: ajnavarro/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@zivkovicmilos zivkovicmilos changed the title Properly set the govDAO implementation on the v3/impl realm too fix: properly set the govDAO implementation on the v3/impl realm Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@ajnavarro ajnavarro force-pushed the fix/init-govdao-on-impl-too branch from 91e3bb4 to 8e4356d Compare April 15, 2025 16:58
Signed-off-by: Antonio Navarro Perez <[email protected]>
@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️gno.land core team Apr 15, 2025
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Apr 15, 2025
@thehowl thehowl merged commit 40c26b8 into gnolang:master Apr 16, 2025
67 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx Apr 16, 2025
@ajnavarro ajnavarro deleted the fix/init-govdao-on-impl-too branch April 16, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants