Skip to content

feat: better unknown account error #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025
Merged

feat: better unknown account error #4166

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f86af2
better error
leohhhn Apr 15, 2025
6da6661
Apply suggestions from code review
leohhhn May 5, 2025
ca28345
Merge branch 'master' into better-uninit-error
thehowl May 9, 2025
7fa9329
Merge branch 'master' into better-uninit-error
thehowl May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gno.land/pkg/sdk/vm/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@
}
creatorAcc := vm.acck.GetAccount(ctx, creator)
if creatorAcc == nil {
return std.ErrUnknownAddress(fmt.Sprintf("account %s does not exist", creator))
return std.ErrUnknownAddress(fmt.Sprintf("account %s does not exist, it must receive coins to be created", creator))

Check warning on line 338 in gno.land/pkg/sdk/vm/keeper.go

View check run for this annotation

Codecov / codecov/patch

gno.land/pkg/sdk/vm/keeper.go#L338 

Added line #L338 was not covered by tests
}
if err := msg.Package.Validate(); err != nil {
return ErrInvalidPkgPath(err.Error())
Expand Down Expand Up @@ -580,7 +580,7 @@
// Validate arguments.
callerAcc := vm.acck.GetAccount(ctx, caller)
if callerAcc == nil {
return "", std.ErrUnknownAddress(fmt.Sprintf("account %s does not exist", caller))
return "", std.ErrUnknownAddress(fmt.Sprintf("account %s does not exist, it must receive coins to be created", caller))

Check warning on line 583 in gno.land/pkg/sdk/vm/keeper.go

View check run for this annotation

Codecov / codecov/patch

gno.land/pkg/sdk/vm/keeper.go#L583 

Added line #L583 was not covered by tests
}
if err := msg.Package.Validate(); err != nil {
return "", ErrInvalidPkgPath(err.Error())
Expand Down
Loading