-
Notifications
You must be signed in to change notification settings - Fork 405
chore(examples): add SetRealm context for testing on loci #4200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Yes - #4060 broke a bunch of tests due to significant changes, and I wanted to fix the tests under my namespace. I'm starting with fixing my packages, then I'll move on to my realms. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you wish; it's also a personal package :)
This ended up being a straightforward fix.
I needed to explicitly use
testing.SetRealm
to ensure that the realm context was configured properly.