Skip to content

chore(examples): add SetRealm context for testing on loci #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025

Conversation

n2p5
Copy link
Contributor

@n2p5 n2p5 commented Apr 22, 2025

This ended up being a straightforward fix.
I needed to explicitly use testing.SetRealm to ensure that the realm context was configured properly.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Apr 22, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: n2p5/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@n2p5 n2p5 changed the title chore: fix tests loci for new crossing upgrade chore(examples): fix tests loci for new crossing upgrade Apr 22, 2025
@n2p5 n2p5 changed the title chore(examples): fix tests loci for new crossing upgrade chore(examples): add SetRealm context for testing on loci Apr 22, 2025
@jefft0
Copy link
Contributor

jefft0 commented Apr 22, 2025

Hi @n2p5 . There are failed CI checks, but I don't think that your PR is the cause. It looks like PR #4060 changed 293 files and broke some of the CI checks.

@n2p5
Copy link
Contributor Author

n2p5 commented Apr 22, 2025

Hi @n2p5 . There are failed CI checks, but I don't think your PR is the cause. It looks like PR #4060 changed 293 files and broke some of the CI checks.

Yes - #4060 broke a bunch of tests due to significant changes, and I wanted to fix the tests under my namespace. I'm starting with fixing my packages, then I'll move on to my realms.

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you wish; it's also a personal package :)

@n2p5 n2p5 merged commit 17bb02a into gnolang:master Apr 22, 2025
12 of 20 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants