-
Notifications
You must be signed in to change notification settings - Fork 440
fix(gnovm): include missing field in shallow size calculation + add overflow protection #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Villaquiranm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix: #4791
I assume
allocPackageconstant contains header field size ofPkgName.This also fix a minor security issue concerning GetShallowSize overflow.
Note:
In mempackage_type:gnovm/pkg/gnolang/alloc.go:347–364, the shallow size of a package value is estimated by accumulating the memory usage of its FNames, FBlocks, and fBlocksMap fields.is not true anymore.It was remove to be improved in the future: #4302 (comment).
As well almost none of the
gnovalue defined in constant are equal to thegoruntime size.Is it normal?
ref:
gnovm/pkg/gnolang/alloc_test.goref: