Skip to content

Conversation

@aeddi
Copy link
Contributor

@aeddi aeddi commented Nov 21, 2025

This PR introduces several improvements to gnokms and remote signer client / server.

  • Add --raw flag to gnokms auth subcommands for displaying raw output 474500d
  • Add remote signer support to --lazy init 4dfc283 3fb5209 82a1812
  • Add arguments validation for gnokms auth subcommands d1aa6b5
  • Various bug fixes, typo corrections, and cleanup

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Nov 21, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: aeddi/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 90.41096% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gno.land/cmd/gnoland/start.go 45.45% 2 Missing and 4 partials ⚠️
tm2/pkg/bft/privval/signer/remote/client/conn.go 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@sw360cab sw360cab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sw360cab sw360cab moved this from Triage to In Progress in 🧙‍♂️gno.land core team Nov 24, 2025
@sw360cab sw360cab self-assigned this Nov 24, 2025
@aeddi aeddi marked this pull request as draft November 24, 2025 12:51
@aeddi aeddi marked this pull request as ready for review November 27, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤝 contribs 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related

Projects

Status: In Progress
Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants