-
Notifications
You must be signed in to change notification settings - Fork 440
fix(avl): add missing checks in avl package #4908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Davphla
wants to merge
8
commits into
gnolang:master
Choose a base branch
from
Davphla:fix/avl-signed-size
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−3
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
df7ef3f
fix(avl): add index and size overflow checks in GetByIndex and traver…
Davphla 8952f3e
fix(avl): add overflow checks for height and size in calcHeightAndSize
Davphla 0d749ae
fix(pager): add panic for invalid page number or page size in GetPage…
Davphla c9c1ca5
fix(avl): remove panic on negative offset
Davphla e45d9d4
fix(avl): remove panic on negative limit in TraverseByOffset
Davphla 8ecbfd6
fix(pager): remove check on negative pageNumber, as it should be supp…
Davphla 6f4c9f2
Merge branch 'master' into fix/avl-signed-size
Davphla d161af2
fix(avl): reverse unnecessary change
Davphla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
nitpick: I think it is better you can have this change reverted to avoid reviewing uneccessary changes
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition is not return first, therefore it is hard to read and should be change (As I've done in #4889). If not done in this PR, it should be done in another.