Skip to content

Conversation

@aeddi
Copy link
Contributor

@aeddi aeddi commented Nov 27, 2025

Benchops has been broken since we fixed a gnovm issue in #4376.
That change (https://github.com/ltzmaxwell/gno/blob/9aea6d5a7117ac775d5d2fb22decb44733d93e72/gnovm/pkg/gnolang/store.go#L492-L495) caused loadObjectSafe() function to call itself recursively: loadObjectSafe -> fillPackage -> GetBlock -> GetObject -> GetObjectSafe -> loadObjectSafe.
Since benchops storage did not support recursive calls, the tool was panicking.

This PR:

  • Fixes the panic by adding support for recursive store calls in benchops storage. 9372dc3
  • Adds a GitHub Actions workflow that runs benchops on every PR to prevent future regressions and upload results as artifacts. ee7d735
  • Applies minor documentation fixes. 28a4240 9f96bd4

@aeddi aeddi self-assigned this Nov 27, 2025
@github-actions github-actions bot added 📖 documentation Improvements or additions to documentation 📦 🤖 gnovm Issues or PRs gnovm related 🚀 ci labels Nov 27, 2025
@aeddi aeddi requested a review from zivkovicmilos November 27, 2025 17:32
@Gno2D2 Gno2D2 requested a review from a team November 27, 2025 17:32
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Nov 27, 2025

🛠 PR Checks Summary

🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: aeddi/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^docs/ (filename: docs/builders/deploy-packages.md)

Then

🔴 Requirement not satisfied
└── 🔴 And
    ├── 🟢 Or
    │   ├── 🟢 Pull request author is a member of the team: tech-staff
    │   └── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request(with state "APPROVED")
    └── 🔴 Or
        ├── 🔴 Pull request author is a member of the team: devrels
        └── 🔴 At least 1 user(s) of the team devrels reviewed pull request(with state "APPROVED")

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 documentation Improvements or additions to documentation 🚀 ci 📦 🤖 gnovm Issues or PRs gnovm related

Projects

Status: No status
Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants