-
Notifications
You must be signed in to change notification settings - Fork 445
feat(gnovm): support variadic arguments on maketx call #5040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gno.land/pkg/sdk/vm/keeper.go
Outdated
| cx := xn.(*gno.CallExpr) | ||
| if cx.Varg { | ||
| panic("variadic calls not yet supported") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is filled when a call expression is in the form of Fn(slice...); it is actually impossible in this case, because we construct the expression ourselves and it is in the form of Fn(arg0, arg1, arg2).
Looks like it was meant to be a condition on the function, but it was actually put here.
I think you can remove this if.
(btw marc no longer works for us)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done here 9c23216
|
Little thought, think of also update the related docs! |
closes #1611