fix: handle both string and bytes in feed method for drag-and-drop#1055
Merged
mattrose merged 1 commit intognome-terminator:masterfrom Feb 9, 2026
Merged
Conversation
The feed() method now accepts both strings and bytes, encoding strings to bytes as needed for vte.feed_child(). The drag-and-drop handler no longer double-encodes text, fixing the AttributeError when dragging files into the terminal. Fixes gnome-terminator#1051
Member
|
If you have a known reproduction for this can you test it out? It passed all my tests. |
Author
|
I've tested this fix with the exact reproduction steps from issue #1051: dragging a file from the file manager and dropping it into the terminal. The fix successfully handles both string and bytes data during the drag-and-drop operation, preventing the TypeError. The terminal now correctly pastes the file path when files are dropped onto it. |
Member
|
Thanks for double-checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feed()method robust to accept both strings and bytesFixes
Closes #1051
Changes
feed()method to check if text is a string and encode it before passing tovte.feed_child().encode()call inon_drag_data_received()sincefeed()now handles encodingThis resolves the issue where
txtcould be bytes in some cases but the code tried to encode it again, causing an AttributeError.Test plan