fix: convert enabled string to boolean in custom commands#1056
Open
dmzoneill wants to merge 1 commit intognome-terminator:masterfrom
Open
fix: convert enabled string to boolean in custom commands#1056dmzoneill wants to merge 1 commit intognome-terminator:masterfrom
dmzoneill wants to merge 1 commit intognome-terminator:masterfrom
Conversation
The enabled flag from config was stored as string 'False'/'True' instead of being converted to boolean. This caused disabled commands to still appear in the right-click menu because non-empty strings are truthy in Python. Now properly converts string values to boolean. Fixes gnome-terminator#1047
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
The
enabledflag from config was being stored as a string ('False' or 'True') instead of being converted to boolean. Since non-empty strings are truthy in Python, the expressions["enabled"] and s["enabled"] or Falsewould evaluate to the string "False" for disabled commands, causing them to still appear in the menu.The fix:
s.get("enabled", False)for safer accessTesting
Fixes #1047