Skip to content

Conversation

@rishabhjamwal
Copy link

Summary

This PR improves the validation of outcomeSlotCount in splitPosition and mergePositions. Previously, the require statement only checked outcomeSlotCount > 0, which allowed unintended behavior when outcomeSlotCount == 1.

Changes

  • Updated the require statements in splitPosition and mergePositions to ensure outcomeSlotCount > 1.

Impact

  • This is not a critical vulnerability but a code clarity improvement.
  • Normalizing outcomeSlotCount ensures that functions behave as intended and avoids confusion in logic interpretation.

Testing

  • Verified that conditions with only one outcome cannot be split or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant