fix(governance): flatten nested AVL tree for voting info storage #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not met Change to process as `StatusRejected` based on `IsPassed()` after voting ends
- Modified `NewProposalTextData()` and `NewProposalExecutionData()` in `proposal_data.gno` to create non-applicable fields as `nil`. - Added explicit error handling in the validation logic of `proposal_data.gno` for cases where `communityPoolSpend`/`execution` is `nil`, and modified `ParameterChangesInfos()` to return an empty result when nil. - Updated `CommunityPoolSpendTokenPath()` in `proposal.gno` to safely return an empty string when `communityPoolSpend` is `nil`.
Replace nested AVL tree structure with single tree using composite keys (`proposalID:voter`). - Eliminate write amplication on vote updates - Removes need to pre-create empty trees for each proposal - Simplifies `Get`/`Set` operations to single-item access | Operation | Before (Nested Tree) | After (Composite Key) | |-----------|----------------------|-----------------------| | Vote Storage | O(log P) + O(log V) + full subtree serialization | O(log N) single entry only | | Vote Lookup | O(log P) + O(log V) two traversals | O(log N) single traversal | | Per-Proposal Full Iteration | O(V) only votes for that proposal | O(N) full iteration + prefix filter | - P = number of proposals, V = votes per proposal, N = total votes
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
notJoon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace nested AVL tree structure with single tree using composite keys (
proposalID:voter).Get/Setoperations to single-item access