feat: goo (gno optimistic oracle) #16

Intermarch3 · 2025-10-09T21:16:11Z

Description

In my journey to upskill on Gno.land, my first significant project is leveraging my knowledge of existing Ethereum smart contracts to implement an optimistic oracle, inspired by UMA Optimistic Oracle and their use in the well-known dApp Polymarket.
Here is a simplified implementation.

This was a previous pr on the gno repo (gnolang/gno#4681) that we moved here.

Intermarch3 · 2025-10-09T21:18:19Z

Left to do :

Test by hand the entire flow to check if nothing was broken during the update.
Add Gno tests
fix exposed objects
create CLI tool to use the oracle easly
Enhance the render page

packages/r/intermarch3/goo/court.gno

leohhhn

leaving a few comments

leohhhn · 2025-10-18T03:06:40Z

packages/r/intermarch3/goo/court.gno

+type Vote struct {
+	RequestId   string
+	Voter       address
+	TokenAmount int64
+	Hash        string
+	Value       int64
+	Revealed    bool
+}
+
+type Voter struct {
+	HasVoted  bool
+	VoteIndex int64
+}
+
+type Dispute struct {
+	RequestId       string
+	Votes           []Vote
+	NbResolvedVotes int64
+	Voters          *avl.Tree
+	IsResolved      bool
+	WinningValue    int64
+	EndTime         time.Time
+	EndRevealTime   time.Time
+}


nitpick: could be in types.gno, since you already have a few.

✅ 6ed3498

leohhhn · 2025-10-18T03:06:51Z

packages/r/intermarch3/goo/court.gno

+}
+
+var (
+	Disputes        = avl.NewTree()


should this be exported?

Why not, could be used to follow initial request resolution on other contracts.

methods on exposed objects allow anyone to modify this object, for example here, anyone can call goo.Disputes.Set("eve", data)

if you want to expose this data safely, you should exposed a safe version, like a rotree wrapper

✅ 31fc552
Fixed it by having this variable private, and the value is still accessible with getters.

leohhhn · 2025-10-18T03:09:31Z

packages/r/intermarch3/goo/README.md

+
+## Architecture
+
+The oracle is composed of three main contracts:


It's one contract though, isn't it? You just listed 3 files

my bad, wanted to say "3 main files"
✅ 6ed3498

leohhhn · 2025-10-18T03:12:07Z

packages/r/intermarch3/goo/README.md

+**2. Propose a Value**
+```bash
+# Propose "Yes" (value 1) (replace ID with the actual ID returned from the RequestData call)
+gnokey maketx call -pkgpath "gno.land/r/intermarch3/oo" -func "ProposeValue" -args "ID" -args "0" -gas-fee 1000000ugnot -gas-wanted 10000000 -send "2000000ugnot" -broadcast -chainid "dev" -remote "tcp://127.0.0.1:26657" <proposer-key-name>
+```


A nice addition would be to suggest (and maybe even build) a Go program to suggest values using gnoclient

leohhhn · 2025-10-18T03:14:24Z

packages/r/intermarch3/goo/render.gno

+		table = append(table, renderRequest(value.(DataRequest))...)
+		return false
+	})
+	msg += md.ColumnsN(table, 4, false)
+	if len(table) == 4 {
+		msg += md.Paragraph("No current requests.")
+	}


nitpick: you could probably add a newline here and there for readability

✅ 6ed3498

packages/r/intermarch3/goo/render.gno

leohhhn · 2025-10-18T03:15:37Z

packages/r/intermarch3/goo/resolver.gno

+	} else {
+		if request.YesNoQuestion {
+			return resolveYesNo(*dispute)
+		} else {
+			return resolveNumeric(*dispute)
+		}
+	}


This else is useless, you can just put the logic in the function body after the error return above

✅ 6ed3498

this hasn't been fixed as far as i see

leohhhn · 2025-10-18T03:16:29Z

packages/r/intermarch3/goo/court.gno

+func init() {
+	VoteToken = newOOToken("Gno Optimistic Oracle Token", "goot", 6)
+}


nit: you can init this at the var block above

✅ 6ed3498

leohhhn

submitting some feedback

leohhhn · 2025-11-17T13:18:29Z

packages/r/intermarch3/goo/court.gno

+	if _, exists := disputes.Get(id); exists {
+		panic("error: Dispute for this request already exists.")
+	}
+	dispute := Dispute{


you could set this as a pointer so that later you can simply fetch and change the object in place without having to set it again

✅ 1dd0262

leohhhn · 2025-11-17T13:25:08Z

packages/r/intermarch3/goo/court.gno

+// -- PUBLIC FUNCTIONS --
+
+// BuyInitialVoteToken allows a user to buy their first vote token by sending voteTokenPrice amount of ugnot.
+func BuyInitialVoteToken(_ realm) {


just a heads up; gnot will be non-transferrable upon launch so you will not be able to use it to pay for things (usable only for gas)

its ok, we just need to set the price of the token to 0 ugnot at launch and change it after.

leohhhn · 2025-11-17T13:27:32Z

packages/r/intermarch3/goo/court.gno

+}
+
+// BalanceOfVoteToken returns the number of vote tokens held by the caller.
+func BalanceOfVoteToken(_ realm) int64 {


did you check out GRC20 Tellers? they're exposable so you do not have to have this kind of wrapper function

✅ 3107cbe

leohhhn · 2025-11-17T13:28:11Z

packages/r/intermarch3/goo/court.gno

+	request := res.(DataRequest)
+	if request.Proposer == runtime.PreviousRealm().Address() || request.Disputer == runtime.PreviousRealm().Address() {
+		panic("error: Proposer and Disputer cannot vote in this dispute.")
+	}
+	if dispute.IsResolved {
+		panic("error: Dispute is already resolved.")
+	}
+	if time.Now().After(dispute.EndTime) {
+		panic("error: Vote period has ended.")
+	}
+	amount := VoteToken.BalanceOf(runtime.PreviousRealm().Address())
+	if amount < 1 {


newlines for readability

Suggested change

request := res.(DataRequest)

if request.Proposer == runtime.PreviousRealm().Address() || request.Disputer == runtime.PreviousRealm().Address() {

panic("error: Proposer and Disputer cannot vote in this dispute.")

}

if dispute.IsResolved {

panic("error: Dispute is already resolved.")

}

if time.Now().After(dispute.EndTime) {

panic("error: Vote period has ended.")

}

amount := VoteToken.BalanceOf(runtime.PreviousRealm().Address())

if amount < 1 {

request := res.(DataRequest)

if request.Proposer == runtime.PreviousRealm().Address() || request.Disputer == runtime.PreviousRealm().Address() {

panic("error: Proposer and Disputer cannot vote in this dispute.")

}

if dispute.IsResolved {

panic("error: Dispute is already resolved.")

}

if time.Now().After(dispute.EndTime) {

panic("error: Vote period has ended.")

}

amount := VoteToken.BalanceOf(runtime.PreviousRealm().Address())

if amount < 1 {

✅ 3107cbe

leohhhn · 2025-11-17T13:28:48Z

packages/r/intermarch3/goo/court.gno

+	caller := runtime.OriginCaller()
+	coins := banker.OriginSend()
+	if len(coins) != 1 || coins.AmountOf("ugnot") != voteTokenPrice {
+		panic("error: Must send exactly " + strconv.Itoa(int(voteTokenPrice/1_000_000)) + " gnot to get a vote token.")


nit: could be easier with ufmt

✅ 3107cbe

leohhhn · 2025-11-17T16:11:29Z

packages/r/intermarch3/goo/resolver.gno

+	"chain"
+	"chain/runtime"
+)
+


would you mind adding a short godoc?

✅ 3107cbe

leohhhn · 2025-11-17T16:11:40Z

packages/r/intermarch3/goo/resolver.gno

+	}
+}
+
+func resolveYesNo(dispute Dispute) int64 {


same as above for godoc

✅ 3107cbe

leohhhn · 2025-11-17T16:11:48Z

packages/r/intermarch3/goo/resolver.gno

+	var winningValue int64
+	var weight int64


can be a var block

✅ 3107cbe

leohhhn · 2025-11-17T16:12:30Z

packages/r/intermarch3/goo/resolver.gno

+		winningValue = 0
+		weight = noVotes
+	}
+	rewardAndSlachVoters(dispute, winningValue, weight)


typo: slach

✅ 3107cbe

leohhhn · 2025-11-17T16:26:09Z

packages/r/intermarch3/goo/resolver.gno

+	// Find the value with the most token weight
+	var winningValue int64
+	var maxWeight int64


var block

✅ 3107cbe

leohhhn · 2025-11-17T17:15:19Z

packages/r/intermarch3/goo/render.gno

+	msg += md.HorizontalRule()
+
+	// List last 5 resolved requests and build table
+	msg += md.H2("Last 5 Resolved requests :")


Suggested change

msg += md.H2("Last 5 Resolved requests :")

msg += md.H2("Last 5 Resolved requests:")

✅ 3107cbe

leohhhn · 2025-11-17T17:16:06Z

packages/r/intermarch3/goo/oracle.gno

+// RequestData allows a user to request data from the oracle.
+// `requesterReward` value needs to be sent to the contract as a reward
+// You need to ask a question that can be answered with a single number like a yes/no question (0 or 1) or a specific value (e.g. ETH/USD price).
+func RequestData(_ realm, ancillaryData string, yesNoQuestion bool, deadline int64) string {


would be good to mention what the unit for the deadline is; seconds, a specific block, etc.

✅ 3107cbe

leohhhn · 2025-11-17T17:16:50Z

packages/r/intermarch3/goo/oracle.gno

+
+	id := idGenerator.Next().String()
+
+	request := DataRequest{


Pointers in AVL Trees in general are better.

✅ 1dd0262

leohhhn · 2025-11-17T17:17:29Z

packages/r/intermarch3/goo/oracle.gno

+
+	coins := banker.OriginSend()
+	if len(coins) != 1 || coins.AmountOf("ugnot") != requesterReward {
+		panic("error: Incorrect reward amount sent. Required: " + strconv.FormatInt(requesterReward, 10) + " ugnot.")


nit: ufmt could be better

✅ 3107cbe

leohhhn

I left a few more comments, but overall this is good. Let's get the ball rolling on this more, it's super useful and really needed. Sorry for the slow turnaround on the review.

Intermarch3 added 2 commits October 9, 2025 23:04

add: goo (gno optimistic oracle)

24677ba

fix: remove natspec doc

15d24a3

Intermarch3 mentioned this pull request Oct 9, 2025

feat(example): Optimistic Oracle implementation gnolang/gno#4681

Closed

Intermarch3 added 2 commits October 15, 2025 10:10

fix: render functions

91e0309

fix: var type errors

b7a5176

leohhhn reviewed Oct 16, 2025

View reviewed changes

packages/r/intermarch3/goo/court.gno Show resolved Hide resolved

leohhhn reviewed Oct 18, 2025

View reviewed changes

Intermarch3 mentioned this pull request Oct 19, 2025

Lucas's builder journey gnolang/hackerspace#128

Open

Intermarch3 added 2 commits October 19, 2025 11:49

fix: errors and Leon's comment

6ed3498

fix: format

69790d9

Intermarch3 requested a review from leohhhn October 19, 2025 09:55

Intermarch3 added 5 commits October 19, 2025 15:20

test: add a part of the oracle tests

618501a

add: oracle unit tests

c7a7d93

fix: format and more

561610f

fix: exposed vars security issue

31fc552

fix: format

3b197cb

Intermarch3 marked this pull request as ready for review October 25, 2025 09:22

Intermarch3 mentioned this pull request Nov 3, 2025

feat: goo cli #20

Open

leohhhn reviewed Nov 17, 2025

View reviewed changes

leohhhn approved these changes Nov 17, 2025

View reviewed changes

Intermarch3 added 3 commits November 25, 2025 15:25

fix: review comments

3107cbe

refacto: use pointer in avl tree

1dd0262

fix: format

681a1ef


		## Architecture

		The oracle is composed of three main contracts:

	msg += md.H2("Last 5 Resolved requests :")
	msg += md.H2("Last 5 Resolved requests:")

feat: goo (gno optimistic oracle) #16

Are you sure you want to change the base?

feat: goo (gno optimistic oracle) #16

Uh oh!

Conversation

Intermarch3 commented Oct 9, 2025

Description

Uh oh!

Intermarch3 commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

leohhhn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leohhhn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Intermarch3 commented Oct 9, 2025 •

edited

Loading