feat: basic CI #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
currently blocked by gnolang/gno#4739 |
moul
reviewed
Sep 23, 2025
gfanton
requested changes
Sep 23, 2025
Contributor
gfanton
left a comment
gfanton
left a comment
There was a problem hiding this comment.
Check my comments. check monorepo workflows templates; they should be simple enough to adapt it here (not as a template).
Also (not mendatory in this PR) but using go.mod to vendor gno would be better IMO. As long a we have some flow to update it frequently (e.g. once a week)
.github/workflows/gno-test.yaml
Outdated
Comment on lines
36
to
37
| - name: Expose GOBIN on PATH | ||
| run: echo "${GOBIN}" >> "$GITHUB_PATH" |
Contributor
Author
There was a problem hiding this comment.
After adding the go.mod, it's needed so that the CI knows where the installed gno binary is.
Contributor
Author
|
Hey @gfanton thanks for the review. I reworked the CI and now we use a go.mod file, with a nicer flow and proper execution. Can you please check it out again? |
Contributor
Author
|
Also added a Makefile which uses local tools. |
gfanton
requested changes
Sep 30, 2025
Co-authored-by: Guilhem Fanton <[email protected]>
Contributor
Author
|
self merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.