feat: add Pierre115's home #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leohhhn
suggested changes
Sep 22, 2025
Contributor
leohhhn
left a comment
leohhhn
left a comment
There was a problem hiding this comment.
Cool. I left some more comments - please see them below.
leohhhn
changed the title
Contributor
|
Also renamed the PR ^ |
Contributor
Author
|
Thank you for your feedback. The code has been corrected and updated ! |
Davphla
approved these changes
Sep 28, 2025
leohhhn
suggested changes
Sep 29, 2025
Contributor
leohhhn
left a comment
leohhhn
left a comment
There was a problem hiding this comment.
A bit more work needed; check out my comments below.
When you work on things that the reviewers requested, you should make a commit for each fix, and then post the commit link in the related conversation. this makes it a lot easier for the reviewers. Check out some of the PRs on the monorepo to see examples
Contributor
|
Can you please check the CI, and also reply to comments? |
Contributor
|
Ci still failing! |
leohhhn
approved these changes
Oct 17, 2025
leohhhn
reviewed
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pierre115's Home Page
This PR adds a simple Home page.
Please feel free to give me feedback !
Preview