This repository was archived by the owner on Jul 19, 2022. It is now read-only.
meson: use system dependencies instead of subproject#226
Open
marcusmueller wants to merge 1 commit into
Open
Conversation
Since PMT(f) is rather central, let's keep the default source the subproject, but add an `external_pmt` meson option. Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
Comment on lines
+48
to
+57
| # Use internal PMT by default – we expect some movement here still | ||
| # But: offer option to look for external PMT lib; this should make package | ||
| # Maintainers a bit happier | ||
| if (get_option('external_pmt')) | ||
| # pmtf_dep = dependency('pmtf', version : '>=0.0.2') | ||
| pmtf_dep = dependency('pmtf', fallback : [ 'pmt' , 'pmtf_dep' ]) | ||
| else | ||
| libpmtf = subproject('pmt') | ||
| pmtf_dep = libpmtf.get_variable('pmtf_dep') | ||
| endif |
There was a problem hiding this comment.
You don't really need a custom option.
Meson has these builtins:
--wrap-mode=forcefallback-- prefer subprojects, always--force-fallback-for=pmtf-- prefer subprojects for the pmtf dependency, specifically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PMT(f) is rather central, let's keep the default source the subproject, but add an
external_pmtmeson option.This mirrors what gnuradio/pmt#46 did to pmt (where it only affected CLI11 selection).
The motivation here is that we can now have a pmtf distro package, and let the newsched distro package build-depend on it.