Conversation
Instead of printing out a warning, the underlying file reading function creates proper NSError objects, that are returned to the user. The following initializers were implemented: -[NSData initWithContentsOfFile:options:error:] -[NSData initWithContentsOfURL:options:error:] +[NSData dataWithContentsOfFile:options:error:] +[NSData dataWithContentsOfURL:options:error:] Additionally NSDataReadingOptions was added to NSData.h. Please note that NSDataReadingMappedIfSafe, and NSDataReadingMappedAlways currently have no effect, and need to be implemented properly.
Member
Author
|
CI is broken in master |
Contributor
|
Basically I'm happy to merge this ... It needs trivial whitespace/style tweaks, easily done after merging. More importantly I think it should support memor mapped files (since we supported them long before Apple did), and perhaps shared memory using the new initialiser with a new constant. But those can be done after merging too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of printing out a warning, the underlying file reading function creates proper NSError objects, that are returned to the user.
The following initializers were implemented:
-[NSData initWithContentsOfFile:options:error:]
-[NSData initWithContentsOfURL:options:error:]
+[NSData dataWithContentsOfFile:options:error:]
+[NSData dataWithContentsOfURL:options:error:]
Additionally NSDataReadingOptions was added to NSData.h. Please note that NSDataReadingMappedIfSafe, and NSDataReadingMappedAlways currently have no effect, and need to be implemented properly.