Fix: CFRunLoopRemoveSource crash removing a source from the common modes - #143
Open
DTW-Thalion wants to merge 1 commit into
Open
Fix: CFRunLoopRemoveSource crash removing a source from the common modes#143DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
DTW-Thalion
force-pushed
the
fix-cfrunloop-common-modes-remove
branch
from
July 24, 2026 15:22
bc57e33 to
3193a4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFRunLoopCommonModesRemove assigned the Boolean result of CFArrayContainsValue to a CFIndex and passed it to CFArrayRemoveValueAtIndex. Removing an object from kCFRunLoopCommonModes therefore removed index 1 when the object was present (or index 0 when it was absent) rather than the object's actual index, reading past the end of _commonObjects and crashing CFRunLoopRemoveSource/RemoveObserver/RemoveTimer for any object added to the common modes.
Use CFArrayGetFirstIndexOfValue, which returns the real index or kCFNotFound, matching CFRunLoopRemoveSource_nolock.
Tests/CFRunLoop/common_remove.m segfaults before this change and passes after. Verified against Apple CoreFoundation.