Tests: aggregate high-volume CFDictionary assertions - #157
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
The general.m and bridge.m large-dictionary loops emitted one passed assertion per iteration, producing thousands of redundant log lines. Collapse each loop into a single assertion covering all keys and report the first offending key only on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The large-dictionary loops in
CFDictionary/general.mandCFDictionary/bridge.mlogged one passed assertion per iteration, which is the main source of the verbose output described in the issue.Each of those loops now runs a single assertion covering all keys instead of one per key. On failure the first offending key is printed before the assertion, so the detail is still available when a test does not pass.
The smaller fixed-size loops in
general.mare aggregated the same way for consistency. Test coverage is unchanged.Closes #156.