CFError: do not test CFErrorCreate with a NULL domain - #78
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
Apple CoreFoundation dereferences the domain, so passing NULL crashes there rather than returning NULL. Only corebase handles it defensively, so the case cannot run on the reference implementation.
DTW-Thalion
force-pushed
the
tests/cferror-create-apple-cf
branch
from
July 24, 2026 15:11
dc4cfd5 to
4d7ecb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFErrorCreate requires a non-NULL domain. On Apple CoreFoundation, passing NULL
dereferences the domain and crashes, so the assertion that it returns NULL only
holds for corebase's defensive handling and cannot run on the reference
implementation. Removing the case lets the suite pass on CoreFoundation; the rest
of the file is unaffected.