Fix the build on apple-apple-apple by casting IMPs correctly. - #2
Open
iamleeg wants to merge 2 commits into
Open
Fix the build on apple-apple-apple by casting IMPs correctly.#2iamleeg wants to merge 2 commits into
iamleeg wants to merge 2 commits into
Conversation
Signed-off-by: Graham Lee <grahamlee@acm.org>
Contributor
|
I think we do not really need IMP caching. we should remove this to make the code more readable. What do you think @iamleeg |
Signed-off-by: Graham Lee <grahamlee@acm.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent versions of the Apple ObjC runtime define
IMPasvoid (*IMP)(void), and the compiler rejects attempts to use functions without casting to a type that matches the signature used at the call site. This PR adds those casts to gdl2. Additionally, it uses the Objective-C runtime API to manipulate an object's class, because theisamember isn't available on all runtimes.