tests: add CGAffineTransform tests - #21
Merged
Merged
Conversation
Contributor
Author
|
@gcasa @fredkiefer who maintains this repo? |
DTW-Thalion
changed the title
DTW-Thalion
force-pushed
the
tests/cgaffinetransform
branch
from
July 25, 2026 12:35
d2d25e9 to
7aec19c
Compare
DTW-Thalion
changed the title
fredkiefer
reviewed
Jul 25, 2026
| @@ -0,0 +1,32 @@ | |||
| # | |||
Member
There was a problem hiding this comment.
Are you sure that this file is actually needed? It does no harm so I will commit it.
fredkiefer
approved these changes
Jul 25, 2026
Contributor
Author
|
It's part of the test template I have setup, I can go back in and remove the unused ones as a hygeine PR once I get the tests in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a gnustep-tests suite for CGAffineTransform under Tests/opal, covering construction (translation, scale, rotation), composition order (Concat and the Scale/Translate/Rotate builders), inversion, application to point/size/rect, and the identity/equality predicates. Expected values were checked against Apple CoreGraphics on a macOS runner.
One divergence is marked hopeful: CGAffineTransformIsIdentity returns true for any transform whose off-diagonal and translation are zero, so a pure scale is misreported as the identity. The fix is sent separately.
Also wires the test suite into CI (runs gnustep-tests in Tests/opal after the build); verified green for both gnustep-1.9 and gnustep-2.0.