Fix: CGImageCreateWithImageInRect reports the cropped size - #31
Open
DTW-Thalion wants to merge 1 commit into
Open
Fix: CGImageCreateWithImageInRect reports the cropped size#31DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CGImageCreateWithImageInRect stored the crop rect but left the image's width and height at the full source size, so CGImageGetWidth and CGImageGetHeight reported the whole image rather than the crop (a 1x1 sub-image reported the parent's size). Drawing already honours the crop via the source rect, so only the reported size was wrong.
Return the crop size from CGImageGetWidth/CGImageGetHeight when a crop is set, and build the backing surface from the full source size (opal_CGImageGetSurfaceForImage) so the crop keeps being applied as the source rect at draw time. Verified by cropping the blue pixel out of a red|blue image: the sub-image reports 1x1 and draws blue.
Makes the sub-image size check in the CGImage tests (#30) pass. Checked against Apple CoreGraphics on a macOS runner.