Fix: reset the colour when setting a fill or stroke colour space - #50
Open
DTW-Thalion wants to merge 1 commit into
Open
Fix: reset the colour when setting a fill or stroke colour space#50DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
CGContextSetFillColorSpace and CGContextSetStrokeColorSpace guarded the components allocation with an inverted null check, so on a successful allocation they logged calloc failed and returned without setting anything, and on an actual failure they would have dereferenced the null pointer. The colour was therefore never reset to the colour space default. Correct the check so the functions build the space's default opaque, zero-intensity colour and set it.
DTW-Thalion
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CGContextSetFillColorSpaceandCGContextSetStrokeColorSpaceallocate a components array and then guard it with an inverted null check:So on a successful allocation they log "calloc failed" and return without setting anything - the functions never reset the colour - and on an actual allocation failure they would fall through and dereference the null pointer.
Corrected to
if (!components). The functions now create the colour space's default opaque, zero-intensity colour and set it, matching CoreGraphics.Verified against Apple: after
SetFillColorSpace(orSetStrokeColorSpace) the current colour is reset to black (0,0,0,255). A regression test is in #49 (marked hopeful there; passes once this is merged).