tests: add CAMediaTimingFunction tests - #14
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
Member
|
I don't see how it actively depends on #12? I'm tempted to merge as is, tests can still be run even without adding dependency installer script, macOS shim for Testing.h, etc But I'm on my phone and can't test if TestInfo causes Testing.h to get generated too. So I'll wait till the minimal changes are done there |
ivucica
approved these changes
Jul 29, 2026
Contributor
Author
|
Stand by - I am just finishing something in libs-gui, and will pop over to see what changes you want in #12 - if it is quick, it will be done within the hour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a gnustep-tests suite for CAMediaTimingFunction under Tests/quartzcore, checking the control points of the named functions (default, linear, ease-in, ease-out, ease-in-ease-out) and a custom function, including the (0,0)/(1,1) endpoints. Expected values were checked against Apple QuartzCore on a macOS runner.
Depends on #12, which adds the Tests/quartzcore scaffolding (GNUmakefile.super, GNUmakefile.postamble). Please merge #12 first.
The test includes <Foundation/NSGeometry.h> for CGFloat because CAMediaTimingFunction.h uses CGFloat without importing a header that defines it; #15 makes the header self-contained.