Add BarMargin option to Bar and HorizontalBar charts#39
Merged
Conversation
This option allows users to control the space between each bar within a series (and in effect the space between series). In addition a bug was discovered where the Painter API may not correctly scale the chart when Markpoints are used. This bug is another permutation of #30 that was undiscovered, and fixed by moving this logic under `defaultRender`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option allows users to control the space between each bar within a series (and in effect the space between series). This PR closes #38.
The option is specified using a float pointer. Although only int values are considered here, the config is defined with a FloatPointer to remain consistent with other optional parameters (we have no precedent for int pointers). Using a pointer allows a user to configure a gap of
0if they want bars touching each other.In addition a bug was discovered where the Painter API may not correctly scale the chart when Markpoints are used. This bug is another permutation of #30 that was undiscovered, and fixed by moving this logic under
defaultRender.