Fix/405 allow dedupe and param alignment #1014
Open
+30
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
requested changes
Aug 26, 2025
Contributor
VojtechVitek
left a comment
VojtechVitek
left a comment
There was a problem hiding this comment.
The CI is red on the slices import.
However, it might start working after #1017 is merged. Mind rebasing once merged?
Contributor
Author
|
Ok, I'll keep an eye on #1017 and rebase once it's merged. |
…pty regex matches
srpvpn
force-pushed
the
fix/405-allow-dedupe-and-param-alignment
branch
from
95305a5 to
0f1258e
Compare
Contributor
Author
|
@VojtechVitek Rebased onto the latest master, all checks are green now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicate and sort methods in Allow for 405 responses to avoid duplicates and unstable order. Restore param/value alignment when regex param branch doesn’t match to prevent panics with Go 1.22 PathValue. All tests pass. Change is backward-compatible; only stabilizes headers and fixes a runtime edge case.