Fix double-counting of bytes in httpFancyWriter.ReadFrom with tee#1078
Closed
Bahtya wants to merge 1 commit intogo-chi:masterfrom
Closed
Fix double-counting of bytes in httpFancyWriter.ReadFrom with tee#1078Bahtya wants to merge 1 commit intogo-chi:masterfrom
Bahtya wants to merge 1 commit intogo-chi:masterfrom
Conversation
When tee is set, ReadFrom uses io.Copy(&f.basicWriter, r) which routes through basicWriter.Write() — already incrementing bytes. The subsequent f.basicWriter.bytes += int(n) line then double-counts the same bytes. Remove the redundant increment since Write() already handles it. Fixes #1067
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a tee writer is set,
ReadFromusesio.Copy(&f.basicWriter, r)which routes data throughbasicWriter.Write(). That method already incrementsb.bytes(line 112). Then line 212 also incrementsf.basicWriter.bytes += int(n), double-counting the same bytes.Solution
Remove the redundant
f.basicWriter.bytes += int(n)line in the tee branch.Write()already handles the counting.The non-tee branch (line 217-218) is correct as-is because
rf.ReadFrom()calls the underlyingResponseWriterdirectly, bypassingbasicWriter.Write().Fixes #1067