-
-
Notifications
You must be signed in to change notification settings - Fork 340
feat: add scheduler lifecycle monitoring <> #785 #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JohnRoesler
merged 9 commits into
go-co-op:v2
from
iyashjayesh:feature/scheduler-monitor
Dec 2, 2025
Merged
feat: add scheduler lifecycle monitoring <> #785 #889
JohnRoesler
merged 9 commits into
go-co-op:v2
from
iyashjayesh:feature/scheduler-monitor
Dec 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Oct 27, 2025
JohnRoesler
reviewed
Oct 27, 2025
JohnRoesler
reviewed
Oct 27, 2025
JohnRoesler
reviewed
Oct 27, 2025
Co-authored-by: John Roesler <[email protected]>
…istered, JobStarted/JobRunning/JobFailed/JobCompleted)
JohnRoesler
reviewed
Nov 17, 2025
…vents for lifecycle, performance, and concurrency limits.
…d `SchedulerMonitor` details with Prometheus example
Contributor
Author
|
@JohnRoesler Apart from the scope we discussed, can you review the PR once? If needed, we can add any missing metrics. So far, I’ve tried to cover all the ones we discussed. |
JohnRoesler
reviewed
Dec 1, 2025
…duler monitor is configured.
JohnRoesler
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive scheduler and job lifecycle monitoring as proposed in #785. This PR adds the complete
SchedulerMonitorinterface with all planned metrics for tracking scheduler health, job execution, and performance.Changes
SchedulerMonitorinterface with 12 event methodsscheduler.go)executor.go)Implemented Metrics
Lifecycle:
SchedulerStarted- Called whenStart()is invokedSchedulerStopped- Called when scheduler stops (before cleanup)SchedulerShutdown- Called whenShutdown()completesJob Management:
JobRegistered- Track jobs added to schedulerJobUnregistered- Track jobs removed from schedulerJobStarted- Job begins executionJobRunning- Job is actively runningPerformance:
JobExecutionTime- EnablesAverageExecutionTimecalculationsJobSchedulingDelay- EnablesSchedulingLagdetectionConcurrencyLimitReached- Detects singleton/limit mode constraintsJob Execution:
JobCompleted- Track successful completionsJobFailed- Track failures (enablesErrorRatecalculation)Derived Metrics (calculable by monitor implementations):
JobFailed / (JobCompleted + JobFailed)JobExecutionTimeeventsJobRegistered - JobUnregisteredJobStarted - (JobCompleted + JobFailed)Use Cases
@JohnRoesler Ready for review! All metrics from the original plan are now implemented and tested.