actions: install-deb: Implement action to install local Debian packages #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
69ff4e0 to
e764a9d
Compare
sjoerdsimons
requested changes
Jun 25, 2020
Member
sjoerdsimons
left a comment
sjoerdsimons
left a comment
There was a problem hiding this comment.
Fwiw i like this approach overall :)
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
e764a9d to
eb4cf97
Compare
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
eb4cf97 to
2cdd04b
Compare
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
2cdd04b to
493a65a
Compare
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
493a65a to
b38e470
Compare
obbardc
requested review from
sjoerdsimons
and removed request for
sjoerdsimons
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
b38e470 to
c39490e
Compare
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
c39490e to
487fd18
Compare
sjoerdsimons
requested changes
Jan 13, 2024
|
Hi. As info, is this PR on-hold, or about to be integrated ? Thanks in advance for the info. |
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
487fd18 to
352234f
Compare
Member
Author
|
I rebased onto main. Still need to fix last review comments. |
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
2 times, most recently
from
3a022de to
6ac8599
Compare
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
6ac8599 to
dd029ab
Compare
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
2 times, most recently
from
5401141 to
c53d38d
Compare
Member
Author
|
@sjoerdsimons @daissi I cleaned up the commits. Can you take a quick look in case there is anything else? I plan to address remaining bits and get this in over the next month. |
obbardc
commented
Dec 1, 2025
obbardc
commented
Dec 1, 2025
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
c53d38d to
b933bf9
Compare
Member
Author
|
@sjoerdsimons can you take a look at the action yaml properties & description before i rework the PR ? Currently not sure about setting |
Since apt commands will also be used by the install-deb action, prepare for it by abstracting the generic apt commands into a wrapper class. Also create a wrapper base class to be able to abstract common action commands into generic functions. Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
b933bf9 to
a2a6d10
Compare
Signed-off-by: Christopher Obbard <[email protected]>
The install-deb action allows local .deb packages to be installed using the apt command, much like the apt action but for local packages rather than for packages retrieved from remote apt repositories. Resolves: go-debos#157 Closes: go-debos#165 Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
a2a6d10 to
8da90ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install-deb action allows local .deb packages to be installed using the apt command, much like the apt action but for local packages rather than for packages retrieved from remote apt repositories.
Resolves: #157