actions: run: Check script exists during recipe verification #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
from
a8a574e to
f4d49c5
Compare
Member
|
fwiw this would be a great change to start adding test for |
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
2 times, most recently
from
27c3f44 to
fb2c1c0
Compare
obbardc
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
from
fb2c1c0 to
8fd0ace
Compare
obbardc
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
2 times, most recently
from
8c6a800 to
5fe7313
Compare
sjoerdsimons
requested changes
Jan 13, 2024
sjoerdsimons
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
from
5fe7313 to
f805d84
Compare
obbardc
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
from
f805d84 to
28eb2d9
Compare
obbardc
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
from
28eb2d9 to
e7ebbf6
Compare
obbardc
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
7 times, most recently
from
4e077b6 to
b943d29
Compare
sjoerdsimons
reviewed
Dec 4, 2025
actions/run_action.go
Outdated
| /* Extract the full script path from the arguments */ | ||
| args := strings.Split(run.Script, " ") | ||
| run.scriptPath = debos.CleanPathAt(args[0], context.RecipeDir) | ||
| run.scriptArgs = args[1:] |
Member
There was a problem hiding this comment.
Rather then doing this in the verifying function and passing it along in the action struct, why not split it out in a function you called in both places?
Member
Author
There was a problem hiding this comment.
done i think; commits need cleaning up if you;re happy with logic
Member
Author
There was a problem hiding this comment.
OK, cleaned up the commits a bit. Hope it;s all good now.
Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
from
b943d29 to
f926a36
Compare
If a script doesn't exist or the permissions are wrong, the recipe exits during the recipe execution. Let's do some early checks in the Verify stage to ensure the script exists on the host filesystem and a basic check that the file has executable permission bit set. This check also follows symlinks. Signed-off-by: Christopher Obbard <[email protected]>
Add a new test case to verify that run actions with scripts actually call a script which exists on the filesystem as well as some other interesting cases, like a script which doesn't exist, symlink scripts and missing files. Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/fix-run-missing-mount
branch
from
2090858 to
ce1e5fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a script doesn't exist or the permissions are wrong, the
recipe exits during execution. Let's check early if the
script exists on the host filesystem and that the file has
executable permission bit set.