Fix kline sample data to be in the correct ordering #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kline data apparently expects its values in the order {close, open, low, high} as opposed to how it is currently (open, close, low, high). When creating the sample charts from this data you'll notice that the candles will be the right color for their actual direction.
Longer term, you could update kline to use the more intuitive format of starting with the open price but this would break existing charts so it's probably better to just update existing labels.
Author
|
I now see that this is actually WAI as in some countries red is used for increases and that the colors are ultimately customizable anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kline data apparently expects its values in the order {close, open, low, high} as opposed to how it is currently (open, close, low, high). When creating the sample charts from this data you'll notice that the candles will be the right color for their actual direction. Longer term, you could update kline to use the more intuitive format of starting with the open price but this would break existing charts so it's probably better to just update existing labels.