Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tests for flags handlers #8

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

thomaspoignant
Copy link
Contributor

@thomaspoignant thomaspoignant commented Oct 25, 2024

Description

Add test for flags handlers

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

@thomaspoignant thomaspoignant marked this pull request as draft October 25, 2024 09:54
@thomaspoignant thomaspoignant force-pushed the chore-test-flag-handler branch from e45ebce to b97be28 Compare October 25, 2024 09:55
@thomaspoignant thomaspoignant changed the title chore: Add test for flags handlers chore: Add tests for flags handlers Oct 25, 2024
@thomaspoignant thomaspoignant force-pushed the chore-test-flag-handler branch from 91593e7 to 4510a9a Compare October 25, 2024 15:36
@thomaspoignant thomaspoignant force-pushed the chore-test-flag-handler branch from f19c370 to ab96b52 Compare October 25, 2024 15:44
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 8 lines in your changes missing coverage. Please review.

Project coverage is 30.96%. Comparing base (f38e84e) to head (51a7c83).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dao/inmemory_impl_mock.go 81.25% 6 Missing ⚠️
main.go 0.00% 1 Missing ⚠️
util/clock.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main       #8       +/-   ##
==========================================
+ Coverage   3.94%   30.96%   +27.02%     
==========================================
  Files         13       14        +1     
  Lines        735      775       +40     
==========================================
+ Hits          29      240      +211     
+ Misses       706      535      -171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant thomaspoignant marked this pull request as ready for review October 25, 2024 19:06
@thomaspoignant thomaspoignant merged commit 07a189c into main Oct 25, 2024
8 checks passed
@thomaspoignant thomaspoignant deleted the chore-test-flag-handler branch October 25, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant