ssh: support multiple builtin SSH server listener #27969
+31
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimized for setups that prevent uses of global listeners (like 0.0.0.0) but still want to serve via multiple addresses. This could be listening on both a IPv4 and IPv6 address while another SSH server is used for server administration. Fixes go-gitea#12418
GiteaBot
added
the
lgtm/need 2
techknowlogick
added
the
type/enhancement
|
I wonder if it would be better to be able to set the socket -> 1.2.3.4:22, 3.11.2.3:2200, ... and only use the ssh_port setting as default port if not set (so in UI ssh_port is used, but you can make gitea listen to any ip/port connections) |
The documented default value was previously not encoded by just was the system would do on an empty string.
Support listening on multiple address with different ports by overridding the default SSH_LISTEN_ADDRESS like `0.0.0.0,127.0.0.1:2022,[::1]:222,::`
|
I think this is easy to implement with an extra port forward tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized for setups that prevent uses of global listeners (like 0.0.0.0) but still want to serve via multiple addresses. This could be listening on both a IPv4 and IPv6 address while another SSH server is used for server administration.
Fixes #12418
I decided to keep the change minimilistic (e.g. don't rename/deprecate the config option; no new integration test). I am happy to adapt the PR if another approach is recommended.