Implementation of required workflows Actions #32374
Open
+682
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
YoukouTenhouin
force-pushed
the
require_action
branch
2 times, most recently
from
9421146 to
717a95e
Compare
YoukouTenhouin
force-pushed
the
require_action
branch
from
717a95e to
fc27bcf
Compare
|
Anyone interested in this? What should I do next to push this forward? |
YoukouTenhouin
force-pushed
the
require_action
branch
from
fc27bcf to
80f51fe
Compare
|
Thank you for the PR. I tested this feature and it works overall. However, I also found some issues.
|
Zettat123
reviewed
Nov 18, 2024
| v, err := actions_service.CreateRequireAction(ctx, orgID, form.RepoName, form.WorkflowName) | ||
| if err != nil { | ||
| log.Error("CreateRequireAction: %v", err) | ||
| ctx.JSONError(ctx.Tr("actions.require_action.creation.failed")) |
There was a problem hiding this comment.
require_action.creation.failed needs an argument
require_action.creation.failed = Create Global Require Action %s Failed.
|
|
||
| if err := actions_service.DeleteRequireActionByID(ctx, id); err != nil { | ||
| log.Error("Delete RequireAction [%d] failed: %v", id, err) | ||
| ctx.JSONError(ctx.Tr("actions.require_action.deletion.failed")) |
There was a problem hiding this comment.
Cannot find actions.require_action.deletion.failed in locale_en-US.ini
modules/actions/workflows.go
Outdated
|
|
||
| func _DetectWorkflows( |
There was a problem hiding this comment.
Please use detectWorkflows as the function name
modules/actions/workflows.go
Outdated
|
|
||
| func _DetectScheduledWorkflows(gitRepo *git.Repository, commit *git.Commit, entries git.Entries) ([]*DetectedWorkflow, error) { |
There was a problem hiding this comment.
Ditto. Please use detectScheduledWorkflows
|
|
||
| // Listing all RequireAction | ||
| func RequireAction(ctx *context.Context) { | ||
| ctx.Data["ActionsTitle"] = ctx.Tr("actions.requires") |
There was a problem hiding this comment.
I don't know what ActionsTitle is used for. Maybe ctx.Data["Title"] = ctx.Tr("actions.require_action") ?
YoukouTenhouin
force-pushed
the
require_action
branch
from
80f51fe to
1e6d469
Compare
…ove WIP Signed-off-by: Alex Lau(AvengerMoJo) <[email protected]>
Signed-off-by: Alex Lau(AvengerMoJo) <[email protected]>
YoukouTenhouin
force-pushed
the
require_action
branch
from
f20eeab to
0e1d64c
Compare
3 tasks
|
Any further progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some offline discussion, it is agreed that @AvengerMoJo will hand over #31869 to me; and AFAIK on Github such scenario is usually handled by creating a new PR to replace the old one, so I'm doing just that.
TL;DR: This PR is the continuation (#31869, #30067) of attempts of implementing global required workflows Actions, as requested in #26666.