Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to figure out attribute checker problem #33901

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Try to figure out attribute checker problem #33901

merged 2 commits into from
Mar 17, 2025
+96 −15

Conversation

wxiaoguang
Copy link
Contributor

For #31600

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 16, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 16, 2025
This was referenced Mar 16, 2025
Merged
Open
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2025
@wxiaoguang
Copy link
Contributor Author

@jpraet

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2025
@lunny lunny merged commit 9d7c02f into go-gitea:main Mar 17, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 17, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2025
lunny pushed a commit that referenced this pull request Mar 17, 2025
@wxiaoguang
Try to figure out attribute checker problem (#33901) (#33902)
9228063 
Backport #33901
@wxiaoguang wxiaoguang deleted the fix-attr-checker branch March 17, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @hiifong @GiteaBot