Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move UI configurations that do not require restarting gitea to take effect to the admin dashboard #33909

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Move UI configurations that do not require restarting gitea to take effect to the admin dashboard #33909

wants to merge 7 commits into from
+697 −240

Conversation

hiifong
Copy link
Member

@hiifong hiifong commented Mar 16, 2025

replace: #33740

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2025
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 16, 2025
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/migrations modifies/frontend labels Mar 16, 2025
@lunny lunny added this to the 1.24.0 milestone Mar 16, 2025
lunny
lunny reviewed Mar 16, 2025
View reviewed changes
@lunny
Copy link
Member

lunny commented Mar 16, 2025

The old configuration in setting module should be removed to reduce confusion.

wxiaoguang
wxiaoguang requested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I do not think this change is right.

Most setting options here are "user settings", it should belong to user's preference.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2025
@hiifong
Copy link
Member Author

hiifong commented Mar 17, 2025

Sorry but I do not think this change is right.

Most setting options here are "user settings", it should belong to user's preference.

Now the migration is the configuration in the ini file, these configurations currently belong to the global configuration, not the user preferences, you mentioned the user preferences configuration we will implement in the next pr, what do you think?

@wxiaoguang
Copy link
Contributor

Now the migration is the configuration in the ini file, these configurations currently belong to the global configuration, not the user preferences, you mentioned the user preferences configuration we will implement in the next pr, what do you think?

If there is a widely-known roadmap, then we can "implement it in the next pr".

For this feature, at least it is not clear to me what's your plan. What the final solution look like?

  • Should we keep or remove these ini options?
    • If keep, how to make the ini-options and db-options co-exist.
    • If remove, how to make users could set initial values for the config options.
  • What the user-setting system would look like.
  • If an option should be a user option, how to make it work with system option?
  • What kinds of options should be supported?
    • ini-only option
    • system-wide db option (inherit legacy ini option?)
    • user-setting db option (inherit system-wide option and inherit legacy ini option?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny left review comments

@wxiaoguang wxiaoguang wxiaoguang requested changes

Assignees
No one assigned
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/api This PR adds API routes or modifies them modifies/frontend modifies/go Pull requests that update Go code modifies/migrations modifies/templates This PR modifies the template files modifies/translation size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hiifong @lunny @wxiaoguang @GiteaBot