Fix doctor deleting orphaned issues attachments #34142
Open
+39
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
hiifong
reviewed
Apr 9, 2025
hiifong
approved these changes
Apr 10, 2025
GiteaBot
added
lgtm/need 1
yp05327
reviewed
May 9, 2025
| @@ -323,3 +323,32 @@ func deleteIssue(ctx context.Context, issue *issues_model.Issue) error { | |||
|
|
|||
| return committer.Commit() | |||
| } | |||
|
|
|||
| // DeleteOrphanedIssues delete issues without a repo | |||
| func DeleteOrphanedIssues(ctx context.Context) error { | |||
There was a problem hiding this comment.
Can some codes above be used in this function?
e.g. also remove issue actions, other things which is assigned to the orphaned issue?
There was a problem hiding this comment.
I think it could be. But that will need much more changes. This PR will only fix the bug when deleting attachments. That could be another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug when deleting orphaned issues attachments. The attachments maybe stored on other storages service rather than disk.