Skip to content

Add migrations tests #34456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

Add migrations tests #34456

merged 3 commits into from
May 15, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented May 13, 2025 •
edited
Loading

Fix #34455

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/migrations labels May 13, 2025
@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 backport/v1.24 This PR should be backported to Gitea 1.24 labels May 13, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 14, 2025
@lunny lunny mentioned this pull request May 15, 2025
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 15, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) May 15, 2025 16:02
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 15, 2025
@techknowlogick techknowlogick merged commit c24f4b3 into go-gitea:main May 15, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone May 15, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 15, 2025
@lunny lunny deleted the lunny/add_test_migration branch May 15, 2025 16:57
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 16, 2025
@lunny @wxiaoguang @GiteaBot
Add migrations tests (go-gitea#34456)
5cb9bf8 
Fix go-gitea#34455

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot mentioned this pull request May 16, 2025
Merged
techknowlogick pushed a commit that referenced this pull request May 16, 2025
@GiteaBot @lunny @wxiaoguang
Add migrations tests (#34456) (#34483)
d2cbe2f 
Backport #34456 by @lunny

Fix #34455

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.24. @lunny, please send one manually. 🍵

go run ./contrib/backport 34456
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label May 18, 2025
lunny added a commit to lunny/gitea that referenced this pull request May 18, 2025
@lunny @wxiaoguang
Add migrations tests (go-gitea#34456)
5c1d568 
Fix go-gitea#34455

Co-authored-by: wxiaoguang <[email protected]>
@lunny lunny mentioned this pull request May 18, 2025
Merged
@lunny lunny added the backport/done All backports for this PR have been created label May 18, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 19, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
94d765d 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix edithook api can not update package, status and workflow_job events (go-gitea#34495)
  Fix url validation in webhook add/edit API (go-gitea#34492)
  Add R-HNF to the TRANSLATORS file (go-gitea#34494)
  Add missing setting load in dump-repo command (go-gitea#34479)
  nix flake update (go-gitea#34476)
  Fix get / delete runner to use consistent http 404 and 500 status (go-gitea#34480)
  Change "rejected" to "changes requested" in 3rd party PR review notification (go-gitea#34481)
  Add migrations tests (go-gitea#34456)
  Fix project board view (go-gitea#34470)
lunny added a commit that referenced this pull request May 20, 2025
@lunny @wxiaoguang
Add migrations tests (#34456) (#34498)
e32030f 
Fix #34455
Backport #34456

Co-authored-by: wxiaoguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@delvh delvh delvh approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/migrations type/bug
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Gitea 1.23.8 updates migration version on failed migration
6 participants
@lunny @GiteaBot @techknowlogick @delvh @hiifong @wxiaoguang